Pause queues #15928
Merged
Pause queues #15928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
|
FAO @lafriks |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
…eues Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
From code point of view looks good to me, will test it on weekend together with my WIP PR |
This comment has been minimized.
This comment has been minimized.
Closed
|
Build seems to be failing now |
|
yeah I must have made a broken merge when I fixed the last conflict. |
Signed-off-by: Andrew Thornton <[email protected]>
|
fixed |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
approved these changes
Jan 21, 2022
|
As an additional thing we can now add warnings for no workers and finally safely handle the case of no worker configurations for redis. |
…redis/levelqueue Signed-off-by: Andrew Thornton <[email protected]>
wxiaoguang
reviewed
Jan 22, 2022
wxiaoguang
reviewed
Jan 22, 2022
wxiaoguang
reviewed
Jan 22, 2022
wxiaoguang
approved these changes
Jan 22, 2022
LGTM, while maybe util.StopTimer(timer) can be used to reduce some code.
Signed-off-by: Andrew Thornton <[email protected]>
|
|
|
Make lgtm work |
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this issue
Jan 23, 2022
* 'main' of https://github.com/go-gitea/gitea: Add packagist webhook (go-gitea#18224) Fix mime-type detection for HTTP server (go-gitea#18370) Always use git command but not os.Command (go-gitea#18363) Add deprecated for LFS_CONTENT_PATH on zh-cn docs (go-gitea#18362) [skip ci] Updated translations via Crowdin Make gitea, gitea-vet future-proof (go-gitea#18361) Pause queues (go-gitea#15928) Disable content sniffing on `PlainTextBytes` (go-gitea#18359) Update github.com/duo-labs/webauthn (go-gitea#18357)
zeripath
added a commit
that referenced
this issue
Jan 24, 2022
Implements the Pausable interface on WrappedQueues and PersistableChannelUniqueQueues Reference #15928 Signed-off-by: Andrew Thornton [email protected]
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
* Start adding mechanism to return unhandled data Signed-off-by: Andrew Thornton <[email protected]> * Create pushback interface Signed-off-by: Andrew Thornton <[email protected]> * Add Pausable interface to WorkerPool and Manager Signed-off-by: Andrew Thornton <[email protected]> * Implement Pausable and PushBack for the bytefifos Signed-off-by: Andrew Thornton <[email protected]> * Implement Pausable and Pushback for ChannelQueues and ChannelUniqueQueues Signed-off-by: Andrew Thornton <[email protected]> * Wire in UI for pausing Signed-off-by: Andrew Thornton <[email protected]> * add testcases and fix a few issues Signed-off-by: Andrew Thornton <[email protected]> * fix build Signed-off-by: Andrew Thornton <[email protected]> * prevent "race" in the test Signed-off-by: Andrew Thornton <[email protected]> * fix jsoniter mismerge Signed-off-by: Andrew Thornton <[email protected]> * fix conflicts Signed-off-by: Andrew Thornton <[email protected]> * fix format Signed-off-by: Andrew Thornton <[email protected]> * Add warnings for no worker configurations and prevent data-loss with redis/levelqueue Signed-off-by: Andrew Thornton <[email protected]> * Use StopTimer Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
…tea#18393) Implements the Pausable interface on WrappedQueues and PersistableChannelUniqueQueues Reference go-gitea#15928 Signed-off-by: Andrew Thornton [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add functionality to pause and resume queues with the ability to hand back unhandled data.
This also now alerts if a queue configuration will result in no workers and no worker scalling (as in #18189) - and will allow no-worker configurations on redis to not result in loss from the queue.