Rename translations dir for integrations #34494
Merged
+55
∄1¤725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will use hassfest to rename the current directories and commit that, but if I do that now review will be hard with the 3000 file limit on GitHub, so I'll hold that off until this is done |
balloob
reviewed
Apr 21, 2020
homeassistant/helpers/translation.py
Outdated
| if is_platform: | ||
| filename = f"{parts[0]}.{language}.json" | ||
| return str(integration.file_path / ".translations" / filename) | ||
|
|
||
| # If it's a component that is just one file, we don't support translations | ||
| # Example custom_components/my_component.py | ||
| if integration.file_path.name != domain: |
There was a problem hiding this comment.
I think that is_platform is now always filtered out by this check?
There was a problem hiding this comment.
Everything should still work as before.
There was a problem hiding this comment.
Took a look at the tests (which passed) and there are checks there for this.
balloob
reviewed
Apr 21, 2020
balloob
reviewed
Apr 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Breaking change
Not yet, but I will create a followup PR before 0.111 that will be breaking.
For now, if the old directory name is used the user will see a warning.
Proposed change
Rename
.translationstotranslationsto make it easier for users copying custom integrations.Loading translations from the old path is kept with a warning that it will be removed in 0.111
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: