The Wayback Machine - https://web.archive.org/web/20220322021043/https://github.com/home-assistant/core/pull/65230
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readthedocs config #65230

Merged
merged 4 commits into from Jan 31, 2022
Merged

Update readthedocs config #65230

merged 4 commits into from Jan 31, 2022

Conversation

scop
Copy link
Member

@scop scop commented Jan 30, 2022

Proposed change

I don't actually know anything about readthedocs config, just happened to read the config docs a bit in context of #62340 and thought I'd do the update.

v1 is deprecated: https://docs.readthedocs.io/en/stable/config-file/v1.html
Align with the minimum version HA supports: https://docs.readthedocs.io/en/stable/config-file/v2.html#build-tools-python

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: #62340
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

.readthedocs.yml Outdated Show resolved Hide resolved
.readthedocs.yml Outdated Show resolved Hide resolved
scop and others added 2 commits Jan 30, 2022
Co-authored-by: Martin Hjelmare <[email protected]>
@scop
Copy link
Member Author

@scop scop commented Jan 30, 2022

Thanks for the fixups, @MartinHjelmare!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Jan 30, 2022
@balloob balloob merged commit 40d871a into dev Jan 31, 2022
25 checks passed
Dev automation moved this from Reviewer approved to Done Jan 31, 2022
@balloob balloob deleted the scop-readthedocs-config-update branch Jan 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants