Update pylint plugin to validate _async_has_devices
#66512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Proposed change
Add
_async_has_devices
to pylint pluginhass_enforce_type_hints.py
. Although not technically limited to it, all existing uses insideconfig_flow.py
are for the call toconfig_entry_flow.register_discovery_flow
. More specifically_async_has_devices
is exclusively used as function name for thediscovery_function
. Thus I think it's safe to add a rule for it inside the pylint plugin.core/homeassistant/helpers/config_entry_flow.py
Lines 153 to 158 in db73ce9
core/homeassistant/helpers/config_entry_flow.py
Line 18 in db73ce9
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: