The Wayback Machine - https://web.archive.org/web/20220322020747/https://github.com/home-assistant/core/pull/66512
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint plugin to validate _async_has_devices #66512

Merged
merged 4 commits into from Feb 14, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 14, 2022

Proposed change

Add _async_has_devices to pylint plugin hass_enforce_type_hints.py. Although not technically limited to it, all existing uses inside config_flow.py are for the call to config_entry_flow.register_discovery_flow. More specifically _async_has_devices is exclusively used as function name for the discovery_function. Thus I think it's safe to add a rule for it inside the pylint plugin.

def register_discovery_flow(
domain: str,
title: str,
discovery_function: DiscoveryFunctionType,
connection_class: str | UndefinedType = UNDEFINED,
) -> None:

DiscoveryFunctionType = Callable[[HomeAssistant], Union[Awaitable[bool], bool]]

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

frenck
frenck approved these changes Feb 14, 2022
Dev automation moved this from Needs review to Reviewer approved Feb 14, 2022
@frenck
Copy link
Member

@frenck frenck commented Feb 14, 2022

I think this is safe to add as well. We can always remove it when it causes issues 👍

@frenck frenck merged commit ab67ba2 into home-assistant:dev Feb 14, 2022
24 of 25 checks passed
Dev automation moved this from Reviewer approved to Done Feb 14, 2022
@cdce8p cdce8p deleted the improve-typing-async_has_devices branch Feb 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants