The Wayback Machine - https://web.archive.org/web/20220929054706/https://github.com/go-gitea/gitea/pull/17156
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages to view watched repos and subscribed issues/PRs #17156

Open
wants to merge 96 commits into
base: main
Choose a base branch
from

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Sep 26, 2021

Adds GitHub-like pages to view watched repos and subscribed issues/PRs
This is my second try to fix this, but it is better than the first since it doesn't uses a filter option which could be slow when accessing /issues or /pulls and it shows both pulls and issues (the first try is #17053).

Closes #16111
Replaces and closes #17053

Screenshot

@codecov-commenter

This comment was marked as outdated.

models/issue.go Outdated Show resolved Hide resolved
models/issue.go Outdated Show resolved Hide resolved
@davidak
Copy link

davidak commented Oct 4, 2021

Just judging the screenshot.

Shouldn't the subscribed issues/PRs be listed on /issues and /pulls like requested in #5484?

Not sure where watched repos would fit.

@qwerty287
Copy link
Contributor Author

qwerty287 commented Oct 4, 2021

This was my first idea too (and I tried it in #17053).
The problems:

  1. As you already noticed, where should the repos be shown?
  2. The used SQL command is complex and could take a while. If it would be added as filters in /issues or /pulls, Gitea would run this SQL command every time, even if it is not the selected filter (e.g. viewing issues created by you), just to count them.
  3. You can't see issues and PR in one list

(The 2. one is the main problem)

@davidak
Copy link

davidak commented Oct 4, 2021

Gitea would run this SQL command every time, even if it is not the selected filter (e.g. viewing issues created by you), just to count them.

I think SQL can easily count items with a dedicated feature? Also, can it be cached?

You can't see issues and PR in one list

I think it makes sense to separate them.

@qwerty287
Copy link
Contributor Author

qwerty287 commented Oct 4, 2021

I think SQL can easily count items with a dedicated feature? Also, can it be cached?

This would be incompatible with the current filter structure and would probably require a big refactor.
I think the counter uses the counter implemented in xorm and I don't know how it works, but I'd say this uses the count feature of SQL.

And personally, I prefer a page where I can see both issues and PRs (but a filter option would be nice, I'll take a look at this).

@qwerty287 qwerty287 requested review from silverwind and lunny and removed request for lunny, lafriks and silverwind Sep 25, 2022
@qwerty287
Copy link
Contributor Author

qwerty287 commented Sep 25, 2022

Again: please review this. This is open for one year now. I really want to get this finished and merged.

@lunny
Copy link
Member

lunny commented Sep 26, 2022

Again: please review this. This is open for almost one year now. I really want to get this finished and merged.

Have you followed @silverwind 's advise? I think it's better to put them near by user's profile.

@qwerty287
Copy link
Contributor Author

qwerty287 commented Sep 26, 2022

I did, and I did it on July 20.

@lunny
Copy link
Member

lunny commented Sep 26, 2022

I did, and I did it on July 20.

Thanks, then could you update the screenshots?

@qwerty287
Copy link
Contributor Author

qwerty287 commented Sep 26, 2022

The site itself still looks like before, just how you can access it has changed (that's what @silverwind requested)

routers/web/user/notification.go Outdated Show resolved Hide resolved
6543
6543 approved these changes Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment