Add doctor commands to interrogate levelDB queues #18732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ConflictedFiles status should always be reset if there are no conflicts this prevents conflicted files being left over. Fix go-gitea#17204 Signed-off-by: Andrew Thornton <[email protected]>
Given the repeated issues here I've just added some plain trace logging which should allow for easier tracing of when processes are created. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
lunny
reviewed
Feb 12, 2022
zeripath
commented
Feb 12, 2022
Gusted
reviewed
Feb 12, 2022
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
reset-conflict-status
branch
from
f4068ad
to
1475c62
Compare
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
It would be useful to verify the autofix logic actually works by adding a test that runs it twice and asserts it does not complain the second time around. Just a suggestion. |
6543
reviewed
Mar 23, 2022
|
Please resolve the conflicts. |
Unfortunately we need to remove the trace logging from the process manager.
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #18732 +/- ##
==========================================
- Coverage 47.44% 47.39% -0.05%
==========================================
Files 1140 1141 +1
Lines 150804 151164 +360
==========================================
+ Hits 71549 71647 +98
- Misses 70788 71036 +248
- Partials 8467 8481 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6543
approved these changes
Jul 12, 2022
Gusted
reviewed
Jul 12, 2022
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
tdesveaux
pushed a commit
to dontnod/fork-gitea
that referenced
this pull request
Oct 18, 2022
tdesveaux
pushed a commit
to dontnod/fork-gitea
that referenced
this pull request
Oct 18, 2022
tdesveaux
pushed a commit
to dontnod/fork-gitea
that referenced
this pull request
Oct 18, 2022
tdesveaux
pushed a commit
to dontnod/fork-gitea
that referenced
this pull request
Oct 18, 2022
tdesveaux
pushed a commit
to dontnod/fork-gitea
that referenced
this pull request
Nov 4, 2022
tdesveaux
pushed a commit
to dontnod/fork-gitea
that referenced
this pull request
Nov 4, 2022
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst looking at #17204 it appears that the unique-queues can end up in a weird corrupt state - I'm not certain how this happens - however the most difficult thing has been that there was no way to detect this.
In this PR I propose two new doctor commands:
The PR also adds a lot of additional tracing logs.