The Wayback Machine - https://web.archive.org/web/20220620154508/https://github.com/go-gitea/gitea/pull/18930
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Stopwatch behavior #18930

Merged
merged 23 commits into from Apr 25, 2022
Merged

Improve Stopwatch behavior #18930

merged 23 commits into from Apr 25, 2022

Conversation

Gusted
Copy link
Member

@Gusted Gusted commented Feb 27, 2022 •
edited by 6543

  • Don't send empty stopwatch over and over again, only send once.
  • Stop interval to update stopwatch's timer when there is no more stopwatch.

@Gusted
Improve Stopwatch behavior
c771b8d 
- Don't send empty stopwatch over and over again, only send once.
- Stop interval to update stopwatch's timer when there is no more stopwatch.
@Gusted
Copy link
Member Author

@Gusted Gusted commented Feb 27, 2022

Tagging performance/cpu as it doesn't have to send data over HTTP for most use-cases(user which are logged in but don't have any stopwatches/timers).

@Gusted Gusted added this to the 1.17.0 milestone Feb 27, 2022
lunny
lunny approved these changes Feb 27, 2022
View changes
delvh
delvh reviewed Feb 27, 2022
View changes
routers/web/events/events.go Outdated Show resolved Hide resolved
wxiaoguang
wxiaoguang reviewed Feb 27, 2022
View changes
web_src/js/features/stopwatch.js Outdated Show resolved Hide resolved
delvh
delvh approved these changes Feb 28, 2022
View changes
@Gusted Gusted requested review from lunny and delvh Feb 28, 2022
@Gusted
Copy link
Member Author

@Gusted Gusted commented Feb 28, 2022

PR has changed pretty significant since e769c24 please re-check.,

jpraet
jpraet reviewed Mar 15, 2022
View changes
modules/eventsource/manager_run.go Outdated Show resolved Hide resolved
@zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 27, 2022

Test failure is related.

Gusted added 2 commits Mar 28, 2022
@Gusted
Fix test
951793c 
- The current test isn't expecting the noise from stopwatch, so simply
but hacky move up the code for notications. No behavior changes or anything.
@Gusted
Merge branch 'main' into improve-watch
83d4d9c
@Gusted
Copy link
Member Author

@Gusted Gusted commented Mar 28, 2022

Should be all good now.

@Gusted
Copy link
Member Author

@Gusted Gusted commented Apr 25, 2022

At this point we're torturing the CI server every so often with new commits, time to get it merged?
image

@6543 6543 merged commit 4e912a6 into go-gitea:main Apr 25, 2022
2 checks passed
@Gusted Gusted deleted the improve-watch branch Apr 25, 2022
zjjhot added a commit to zjjhot/gitea that referenced this issue Apr 26, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d589df5 
* giteaofficial/main:
  Add a new menu in file view to open blame view and fix blame view select range bug (go-gitea#19500)
  Fix two UI bugs: JS error in imagediff.js, 500 error in diff/compare.tmpl
  [skip ci] Updated translations via Crowdin
  Improve Stopwatch behavior (go-gitea#18930)
  Pass gitRepo down to GetRawDiff, since its used for main repo and wiki (go-gitea#19461)
  Use queue instead of memory queue in webhook send service (go-gitea#19390)
  add a directory prefix `gitea-src-VERSION` to release-tar-file (go-gitea#19396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeripath zeripath

@wxiaoguang wxiaoguang

@jpraet jpraet

@lunny lunny

@delvh delvh

Assignees
No one assigned
Labels
kind/enhancement lgtm/done performance/cpu
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Gusted @zeripath @lunny @wxiaoguang @jpraet @delvh @GiteaBot @6543