The Wayback Machine - https://web.archive.org/web/20220328195140/https://github.com/go-gitea/gitea/pull/19145
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong scopes caused by empty scope input (#19029) #19145

Merged
merged 2 commits into from Mar 20, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 19, 2022

Backport #19029

As the title, close #18972

Try to fix:

And there are many bugs in the admin login source page, they can not be fixed easily in this PR, so I just left some FIXMEs.

@zeripath zeripath added this to the 1.16.5 milestone Mar 19, 2022
lunny
lunny approved these changes Mar 20, 2022
Gusted
Gusted approved these changes Mar 20, 2022
@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 20, 2022

thanks!

@wxiaoguang wxiaoguang merged commit a3f3e31 into go-gitea:release/v1.16 Mar 20, 2022
2 checks passed
@zeripath zeripath deleted the backport-19029-v1.16 branch Mar 20, 2022
zeripath added a commit to zeripath/gitea that referenced this issue Mar 23, 2022
 ## [1.16.5](https://github.com/go-gitea/gitea/releases/tag/1.16.5) - 2022-03-23

* BREAKING
  * Bump to build with go1.18 (go-gitea#19120 et al) (go-gitea#19127)
* SECURITY
  * Prevent redirect to Host (2) (go-gitea#19175) (go-gitea#19186)
  * Try to prevent autolinking of displaynames by email readers (go-gitea#19169) (go-gitea#19183)
  * Clean paths when looking in Storage (go-gitea#19124) (go-gitea#19179)
  * Do not send notification emails to inactive users (go-gitea#19131) (go-gitea#19139)
  * Do not send activation email if manual confirm is set (go-gitea#19119) (go-gitea#19122)
* ENHANCEMENTS
  * Use the new/choose link for New Issue on project page (go-gitea#19172) (go-gitea#19176)
* BUGFIXES
  * Fix compare link in active feeds for new branch (go-gitea#19149) (go-gitea#19185)
  * Redirect .wiki/* ui link to /wiki (go-gitea#18831) (go-gitea#19184)
  * Ensure deploy keys with write access can push (go-gitea#19010) (go-gitea#19182)
  * Ensure that setting.LocalURL always has a trailing slash (go-gitea#19171) (go-gitea#19177)
  * Cleanup protected branches when deleting users & teams (go-gitea#19158) (go-gitea#19174)
  * Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140) (go-gitea#19160)
  * Fix NPE /repos/issues/search when not signed in (go-gitea#19154) (go-gitea#19155)
  * Use custom favicon when viewing static files if it exists (go-gitea#19130) (go-gitea#19152)
  * Fix the editor height in review box (go-gitea#19003) (go-gitea#19147)
  * Ensure isSSH is set whenever DISABLE_HTTP_GIT is set (go-gitea#19028) (go-gitea#19146)
  * Fix wrong scopes caused by empty scope input (go-gitea#19029) (go-gitea#19145)
  * Make migrations SKIP_TLS_VERIFY apply to git too (go-gitea#19132) (go-gitea#19141)
  * Handle email address not exist (go-gitea#19089) (go-gitea#19121)
* MISC
  * Update json-iterator to allow compilation with go1.18 (go-gitea#18644) (go-gitea#19100)
  * Update golang.org/x/crypto (go-gitea#19097) (go-gitea#19098)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Mar 23, 2022
zjjhot added a commit to zjjhot/gitea that referenced this issue Mar 25, 2022
…se/v1.16

* giteaofficial/release/v1.16: (53 commits)
  Bump goldmark to v1.4.11 (go-gitea#19201) (go-gitea#19203)
  Changelog for 1.16.5 (go-gitea#19189)
  Fix showing issues in your repositories (go-gitea#18916) (go-gitea#19191)
  Prevent redirect to Host (2) (go-gitea#19175) (go-gitea#19186)
  Fix compare link in active feeds for new branch (go-gitea#19149) (go-gitea#19185)
  Redirect .wiki/* ui link to /wiki (go-gitea#18831) (go-gitea#19184)
  Prevent start panic due to missing DotEscape function
  Fix the bug: deploy key with write access can not push (go-gitea#19010) (go-gitea#19182)
  Try to prevent autolinking of displaynames by email readers (go-gitea#19169) (go-gitea#19183)
  Clean paths when looking in Storage (go-gitea#19124) (go-gitea#19179)
  Cleanup protected branches when deleting users & teams (go-gitea#19158) (go-gitea#19174)
  Ensure that setting.LocalURL always has a trailing slash (go-gitea#19171) (go-gitea#19177)
  Use the new/choose link for New Issue on project page (go-gitea#19172) (go-gitea#19176)
  Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140) (go-gitea#19160)
  Ensure isSSH is set whenever DISABLE_HTTP_GIT is set (go-gitea#19028) (go-gitea#19146)
  Use custom favicon when viewing static files if it exists (go-gitea#19130) (go-gitea#19152)
  Fix NPE /repos/issues/search when not signed in (go-gitea#19154) (go-gitea#19155)
  Fix wrong scopes caused by empty scope input (go-gitea#19029) (go-gitea#19145)
  Fix the editor height in review box (go-gitea#19003) (go-gitea#19147)
  Do not send notification emails to inactive users (go-gitea#19131) (go-gitea#19139)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants