The Wayback Machine - https://web.archive.org/web/20220328093846/https://github.com/scikit-learn/scikit-learn/pull/22962
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Replace pytest.warns(None) in feature_extraction/tests/test_text.py #22962

Merged
merged 1 commit into from Mar 27, 2022

Conversation

yiyangq
Copy link
Contributor

@yiyangq yiyangq commented Mar 26, 2022

Reference Issues/PRs

Related to #22572
Towards #22396

What does this implement/fix? Explain your changes.

Removes the deprecated pytest.warns(None), and replaces it with warnings.catch_warnings().
I believe the expected warning is "UserWarning".

@yiyangq yiyangq marked this pull request as ready for review Mar 26, 2022
Copy link
Member

@jeremiedbb jeremiedbb left a comment

LGTM. Thanks @yiyangq

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan merged commit 2c5058e into scikit-learn:main Mar 27, 2022
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants