build: prevent framing of dev app with X-Frame-Options #24651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the dev app site from being place in an iframe.
josephperrott
added
merge ready
josephperrott
added
the
dev-app preview
|
Deployed dev-app to: https://ng-comp-dev--pr-24651-58a55cd900be81d7db8fce25f8cfd994-6o7cdpqw.web.app |
|
Good security policy to prevent being placed in an iframe, unless we want to allow it, which we don't have a use case for wanting. |
josephperrott
added a commit
that referenced
this issue
Mar 23, 2022
Prevent the dev app site from being place in an iframe. (cherry picked from commit ed9260b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Prevent the dev app site from being place in an iframe.