angular / components Public
master
Commits on Mar 30, 2022
-
fix(cdk/overlay): disable backdrop animation when noop animations are…
… enabled (#24687) Fixes that we weren't disabling the CDK backdrop transition when the noop animations module is used. This has caused test flakes in the past.
-
fix(material-experimental/mdc-dialog): reduce amount of generated CSS
Reduces the amount of CSS generated by the MDC-based dialog by disabling CSS variable callbacks. Also combines a couple of selectors targeting the same element.
-
-
-
fix(cdk-experimental/menu): fix issue where left/right on standalone …
…menu closes it (#24696) * refactor(cdk-experimental/menu): make MenuStack required * fix(cdk-experimental/menu): fix issue where left/right on standalone menu closes it also consolidates some shared trigger logic under the common base class * fixup! fix(cdk-experimental/menu): fix issue where left/right on standalone menu closes it * fixup! fix(cdk-experimental/menu): fix issue where left/right on standalone menu closes it * fixup! fix(cdk-experimental/menu): fix issue where left/right on standalone menu closes it
-
refactor(multiple): run typed forms migration (#24698)
Runs the typed forms migration over all our code.
-
fix(cdk/a11y): live announcer promise never resolved if new announcem…
…ent comes in (#24700) We return a promise that indicates when we've added the live announcer content to the DOM, however the promise will never be resolved if a new message comes in during the 100ms that it takes for us to make the announcement. These changes add some extra logic to ensure it is always resolved. Note that I was also considering rejecting the old promise instead, but that may be a poor experience for users since they may not have control over messages that are coming in from other places in the app. Fixes #24686.
Commits on Mar 29, 2022
-
docs:Fix theme color typo (#23052)
Co-authored-by: Andrew Seguin <[email protected]>
-
-
build: fix codeowners file for api goldens
Updates the codeowners file to reflect the API golden files, fixing that dev-infra is requested unnecessarily on a lot of PRs
-
build: add global types to api golden tests of youtube-player and goo…
…gle-maps We refactored how type resolution works in the API golden test. The Bazel NodeJS linker no longer runs for API golden tests, making the API golden tests more reliable and less reliant on unexpected behavior/side-effects. A consequence is that Microsofts API extractor is no longer able to automatically resolve type definitions like `@types/google.maps`. These now need to be explicity referenced/loaded similar to how it would happen if we'd test the API goldens through the NPM package (using `api_golden_test_npm_package` -- so this is more consistent now).
-
refactor: use explicit specifier for form field control harness re-ex…
…port Instead of using a star export, we should use an explicit specifier for the `@angular/material/form-field/testing/control` re-export. This satisfies Microsoft's API extractor which will complain as it cannot resolve the entry-point. Within an API golden test, first-party packages/entry-points are always considered external and therefore not resolvable.
-
-
fix(cdk-experimental/menu): move shared menu logic to base class (#24645
) * fix(cdk-experimental/menu): move shared menu logic to base class fix(cdk-experimental/menu) make trigger items behave like normal items when pressing left/right * fixup! fix(cdk-experimental/menu): move shared menu logic to base class * fixup! fix(cdk-experimental/menu): move shared menu logic to base class
-
fix(material/snack-bar): ensure that the snack bar always runs inside…
… the NgZone (#24611) Adds an extra call to ensure that the snack bar is inside the NgZone. This is something that has come up several times in internal tests where some API call is stubbed out, pulling the snack bar outside the zone and causing tests to fail when we remove a change detection somewhere. **Note:** I had a hard time reproducing this in our own tests, presumably because the fixture ends up pulling it back into the zone.
-
build: use github access token for docs site monitoring (#24691)
We recently seemed to hit the rate limit in the docs site monitoring job. We can use a Github access token to avoid these rate limit failures. We move the token extraction to a common location where the GCP key is also extracted, and we use a more granular variable name to make sure it's obvious where the key is used (when added to CircleCI)
-
ci: skip ci failure slack notifications for renovate branches (#24692)
We want to skip CI failure Slack notifications for upstream branches which are not actual publish branches. Please enter the commit message for your changes. Lines starting
-
fix(material/list): not working correctly when list item is used as a…
… button (#13617) Based on our selector for `mat-list-item`, we allow it to be a `button`, however we don't do the necessary resets for it to be usable.
-
refactor: switch "material-experimental" away from cross-package rela…
…tive Sass imports
-
fix(material-experimental/mdc-dialog): expose
dialog-legacy-padding
…… mixin Exposes the `dialog-legacy-padding` mixin which seems to be not accessible in the primary Sass entry-point, but being mentioned in the docs.
-
fix(material/datepicker): expose
datepicker-date-range-colors
mixinExposes the `datepicker-date-range-colors` mixin which seems to be not accessible in the primary Sass entry-point, but being mentioned in the docs.
-
refactor: support PnP for experimental package and MDC deps
Yarn PnP requires explicit listing of dependencies used. Since our Sass files/compilations do not use `material-components-web` but rather use the individual `@material/<..>` packages, we need to switch away from the kitchen-sink package. As part of this, we have two options long-term: * Add all individual deps as peer dependencies * Add all individual deps as _direct_ dependencies. The latter seems more convenient for users and we also cannot make any guarantees that a more recent "build" of the `@material/<..>` packages is still compatible. If users would intend to force a more recent MDC version, they could still use a Yarn resolution, or we could also bump our `dependencies` using a `caret` or `tilde` (once we are relying on a rather stable version of MDC -- that is a potential option then)
-
build: configure custom sass compiler to allow for module imports
Workaround until https://docs.google.com/document/d/1yVRAJptClM1YNH2XqdpPOef9rmLMVeo_qTJLM5j1gDo/edit is addressed/resolved. We need to tell Sass how `@angular/<cdk,material,etc>` imports can be resolved so that we can start using them, similar to how NPM-consumers would. This is a key part of making our NPM packages work with Yarn berry, or more generally making our packages not rely on unspecified behavior (our package exports should not allow for deep imports, but currently we rely on those!)
-
-
build: update integration bazel setup to work with Yarn PnP
Our new Yarn PnP integration test unveiled some issues with the tar archive creation that break within Yarn berry. The problem is that Yarn expects a non-collapsing first archive member component. e.g. currently it is: `./package.json`, but Yarn normalizes the path and therefore omits files like the `package.json` completely. The archive member (to match with `yarn pack`) should instead use an actual first component, like `package/package.json`.
-
-
Commits on Mar 28, 2022
-
build: update angular shared dev-infra code to 03f784a (#24506)
Co-authored-by: Renovate Bot <[email protected]>