fix(forms): Update the typed forms migration. #45281
Closed
+150
−369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylhunn
added
action: review
comp: forms
comp: migrations
cross-cutting: types
target: minor
dylhunn
requested review from
alxhub,
devversion,
AndrewKushnir and
crisbeto
and removed request for
alxhub
|
(Sorry for the noise -- accidentally hit the "assignees" section instead of the "reviewers" section.) |
crisbeto
reviewed
Mar 7, 2022
devversion
reviewed
Mar 7, 2022
LGTM overall, but would like to see what you think about @crisbeto's comment/idea
The typed forms migration was previously designed to add `<any>` type parameters to existing forms classes. However, due to some design changes, the new opt-out strategy requires untyped versions of the classes, as introduced in angular#45205 and angular#45268. This PR updates the migration to import these new classes (in an idempotent manner), and replace constructor calls with the new classes. It respects qualified imports as well. Finally, the code has been refactored to move as much common code as possible into `util.ts`.
dylhunn
added
action: merge
|
This PR was merged into the repository by commit d336ba9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this issue
Apr 8, 2022
The typed forms migration was previously designed to add `<any>` type parameters to existing forms classes. However, due to some design changes, the new opt-out strategy requires untyped versions of the classes, as introduced in angular#45205 and angular#45268. This PR updates the migration to import these new classes (in an idempotent manner), and replace constructor calls with the new classes. It respects qualified imports as well. Finally, the code has been refactored to move as much common code as possible into `util.ts`. PR Close angular#45281
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The typed forms migration was previously designed to add
<any>type parameters to existing forms classes. However, due to some design changes, the new opt-out strategy requires untyped aliases the classes, as introduced in #45205 and #45268.This PR updates the migration to import these new classes (in an idempotent manner), and replace constructor calls with the new classes. It respects qualified imports as well.
Finally, the code has been refactored to move as much common code as possible into
util.ts, and the new schematic code is much simpler.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?