fix(animations): apply default params when resolved value is null or undefined #45339
+64
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undefined
The animations package supports adding default parameter values to an animation that will be used as a fallback if some parameters aren't defined. The problem is that they're applied using a spread expression which means that any own property of the animation parameters will override the defaults, even if it resolves to null or undefined. This can lead to obscure errors like "Cannot read property toString of undefined" for an animation that looks like `{params: {foo: undefined}}` with defaults `{foo: 123}`.
I ran into this issue while debugging some test failures on Material.
These changes address the issue by:
1. Applying the defaults if the resolved value is null or undefined.
2. Updating the validation function to use a null check instead of `hasOwnProperty`.
crisbeto
force-pushed
the
animations-nullish-param
branch
from
d50c14c
to
deeac84
Compare
crisbeto
reviewed
Mar 13, 2022
| @@ -2394,6 +2394,42 @@ describe('animation tests', function() { | |||
| expect(hasStyle(element, 'height', '100px')).toBeTruthy(); | |||
| })); | |||
|
|
|||
| it('should apply default params when resolved animation value is null or undefined', () => { | |||
There was a problem hiding this comment.
I was going back-and-forth between doing this versus throwing a proper error. I went with this, because it seemed weird for {foo: undefined, bar: 1} and {bar: 1} to behave differently.
This comment has been minimized.
This comment has been minimized.
Sorry, something went wrong.
crisbeto
added
comp: animations
action: review
target: patch
crisbeto
added
action: merge
alxhub
added
target: minor
|
@crisbeto FYI this doesn't merge cleanly to 13.3.x. |
|
This PR was merged into the repository by commit 2a75754. |
PiyushAgrawal1243
pushed a commit
to PiyushAgrawal1243/angular
that referenced
this issue
Mar 30, 2022
…undefined (angular#45339) The animations package supports adding default parameter values to an animation that will be used as a fallback if some parameters aren't defined. The problem is that they're applied using a spread expression which means that any own property of the animation parameters will override the defaults, even if it resolves to null or undefined. This can lead to obscure errors like "Cannot read property toString of undefined" for an animation that looks like `{params: {foo: undefined}}` with defaults `{foo: 123}`. I ran into this issue while debugging some test failures on Material. These changes address the issue by: 1. Applying the defaults if the resolved value is null or undefined. 2. Updating the validation function to use a null check instead of `hasOwnProperty`. PR Close angular#45339
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this issue
Apr 8, 2022
…undefined (angular#45339) The animations package supports adding default parameter values to an animation that will be used as a fallback if some parameters aren't defined. The problem is that they're applied using a spread expression which means that any own property of the animation parameters will override the defaults, even if it resolves to null or undefined. This can lead to obscure errors like "Cannot read property toString of undefined" for an animation that looks like `{params: {foo: undefined}}` with defaults `{foo: 123}`. I ran into this issue while debugging some test failures on Material. These changes address the issue by: 1. Applying the defaults if the resolved value is null or undefined. 2. Updating the validation function to use a null check instead of `hasOwnProperty`. PR Close angular#45339
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The animations package supports adding default parameter values to an animation that will be used as a fallback if some parameters aren't defined. The problem is that they're applied using a spread expression which means that any own property of the animation parameters will override the defaults, even if it resolves to null or undefined. This can lead to obscure errors like "Cannot read property toString of undefined" for an animation that looks like
{params: {foo: undefined}}with defaults{foo: 123}.I ran into this issue while debugging some test failures on Material.
These changes address the issue by:
hasOwnProperty.