The Wayback Machine - https://web.archive.org/web/20220123183619/https://github.com/angularsen/UnitsNet/issues/374
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure PR follows contribution guideline #374

Open
angularsen opened this issue Jan 13, 2018 · 0 comments
Open

Add tests to ensure PR follows contribution guideline #374

angularsen opened this issue Jan 13, 2018 · 0 comments

Comments

@angularsen
Copy link
Owner

@angularsen angularsen commented Jan 13, 2018

As per #328 (comment)

Having a set of tests to validate that the correct abbreviation notations and symbols are used would be helpful, as we have seen from before that discrepancies tend to creep in over time.

See #328 for the (currently work in progress) guideline, go through the comments and identify what tests to write for the guideline we have arrived at so far. This will evolve over time, but we have enough to start with already.

Update #328 description with the complete list of rules that you gather from the comments, and mark those that are automated by tests with an asterisk and a footnote explaining that below. Then whenever we add new rules to the guideline, we will make it a routine to both update the issue description and add a test case (if feasible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant