The Wayback Machine - https://web.archive.org/web/20220404160455/https://github.com/localstack/localstack/pull/5591
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for #define function in API Gateway velocity templates #5591

Merged
merged 1 commit into from Mar 1, 2022

Conversation

whummer
Copy link
Member

@whummer whummer commented Mar 1, 2022

  • add support for #define function in API Gateway velocity templates. Addresses #5587
  • migrate tests to pytest

Note: some of the logic can be removed once this PR is merged/released: purcell/airspeed#56

@whummer whummer requested a review from calvernaz Mar 1, 2022
@whummer whummer temporarily deployed to localstack-ext-tests Mar 1, 2022 Inactive
Copy link
Contributor

@calvernaz calvernaz left a comment

@whummer thanks for doing this, the code looks good!

@coveralls
Copy link

@coveralls coveralls commented Mar 1, 2022

Coverage Status

Coverage increased (+0.01%) to 87.973% when pulling aedc53e on velocity-define into b492418 on master.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 1, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   50m 40s ⏱️ - 6m 7s
   897 tests ±0     861 ✔️ ±0  36 💤 ±0  0 ±0 
1 099 runs  ±0  1 042 ✔️ ±0  57 💤 ±0  0 ±0 

Results for commit aedc53e. ± Comparison against base commit b492418.

@whummer whummer merged commit ff0ba56 into master Mar 1, 2022
15 checks passed
@whummer whummer deleted the velocity-define branch Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants