The Wayback Machine - https://web.archive.org/web/20220404160640/https://github.com/localstack/localstack/pull/5686
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SERVICES from default docker-compose.yaml #5686

Merged
merged 1 commit into from Mar 16, 2022
Merged

Remove SERVICES from default docker-compose.yaml #5686

merged 1 commit into from Mar 16, 2022

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Mar 16, 2022

This hasn't been necessary for quite some time now and I think this leads to a lot of unnecessary issues.

@dominikschubert dominikschubert requested review from whummer and thrau Mar 16, 2022
@dominikschubert dominikschubert self-assigned this Mar 16, 2022
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests Mar 16, 2022 Inactive
whummer
whummer approved these changes Mar 16, 2022
View changes
Copy link
Member

@whummer whummer left a comment

Cool, great point 👍 🧹

@coveralls
Copy link

@coveralls coveralls commented Mar 16, 2022

Coverage Status

Coverage increased (+0.002%) to 88.379% when pulling 3fda2bf on remove-dockercompose-services into 9e6c151 on master.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 16, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   53m 56s ⏱️ - 1m 39s
   904 tests ±0     868 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
1 106 runs  ±0  1 049 ✔️ ±0  57 💤 ±0  0 ❌ ±0 

Results for commit 3fda2bf. ± Comparison against base commit 9e6c151.

thrau
thrau approved these changes Mar 16, 2022
View changes
Copy link
Member

@thrau thrau left a comment •
edited

awesome {insert kill it with fire}!

@dominikschubert dominikschubert merged commit d186336 into master Mar 16, 2022
15 checks passed
@viren-nadkarni viren-nadkarni deleted the remove-dockercompose-services branch Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer

@thrau thrau

Assignees

@dominikschubert dominikschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dominikschubert @coveralls @whummer @thrau