Skip installing -ext runtime dependencies in CI tests #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Skip installing -ext
runtimedependencies in CI tests - attempt to fix broken build onmaster.We're currently running
make install-testin the CI builds, and thepip install -e ".[cli,runtime,test]"command transitively pulls in theruntimeextras from dependent packages, which we want to avoid.The particular reason why the builds are failing right now is because an upstream dependency has been added to the
runtimeextra which depends onthriftpy2, which in turn requiresgccto build the native extensions.