opendrive: resolve lag and truncate bugs fixes #5936 #5947
+51
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncw
reviewed
Jan 25, 2022
This looks really good - thank you.
Looking things up by ID is always better.
I put some very minor comments about the code inline.
backend/opendrive/opendrive.go
Outdated
| @@ -429,6 +429,12 @@ func (f *Fs) Move(ctx context.Context, src fs.Object, remote string) (fs.Object, | |||
| return nil, err | |||
| } | |||
|
|
|||
| // move_copy will silently truncate new filenames | |||
| if len(leaf) > 255 { | |||
| fs.Debugf("Can't move file: name (%s) exceeds 255 char", leaf) | |||
There was a problem hiding this comment.
The debug message needs an object as its first parameter - this will render as its path in the log.
So something like
fs.Debugf(src, "Can't move file: name %q exceeds 255 chars", leaf)
| if "" != o.id { | ||
| fileInfo := File{} | ||
| err = o.fs.pacer.Call(func() (bool, error) { | ||
| opts := rest.Opts{ |
There was a problem hiding this comment.
We usually define opts outside the Call function as it is essentially a loop.
| return fmt.Errorf("failed to get fileinfo: %w", err) | ||
| } | ||
|
|
||
| o.id = fileInfo.FileID |
There was a problem hiding this comment.
This feels like this should be an if / else with the setting of the o.id etc variables done after the if / else otherwise there is a bit of duplicated code here.
scott-grimes
force-pushed
the
issue-5936
branch
2 times, most recently
from
b0edc45
to
43e9eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What is the purpose of this change?
Resolves two issues with opendrive:
/file/info.jsonin readMetaData when possible (if the object id is already known)Previously all calls in readMetaData relied on the
/folder/itembyname.jsonapi which is buggy: items written to a directory take an arbitrary amount of time to appear via this endpoint, and the file info returned does not include the file hash.move_copyendpoint which silently truncates new filenames to 255 char. rclone (correctly) throws an error when attempting to create a file or directory that surpasses the max length for opendrive, but there is no check performed in the move_copy command. Without such a check files written to the remote may have their names modified unknowingly.Was the change discussed in an issue or in the forum before?
#5936
Checklist