The Wayback Machine - https://web.archive.org/web/20220510165118/https://github.com/pytorch/pytorch/issues/73193
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point exception in mkldnn_convolution #73193

Open
neochristou opened this issue Feb 21, 2022 · 5 comments · May be fixed by #76526
Open

Floating point exception in mkldnn_convolution #73193

neochristou opened this issue Feb 21, 2022 · 5 comments · May be fixed by #76526
Labels
good first issue high priority module: cpu module: error checking module: mkldnn triaged

Comments

@neochristou
Copy link

@neochristou neochristou commented Feb 21, 2022

🐛 Describe the bug

Floating point exception in mkldnn_convolution when stride contains 0s.

Example to reproduce

import torch

self = torch.full((1, 1, 1, 24000,), 1, dtype=torch.float32, requires_grad=False)
weight = torch.full((1, 1, 1, 24000,), 1, dtype=torch.float32, requires_grad=False)
bias = torch.full((1, 1, 1, 24000,), 1, dtype=torch.float32, requires_grad=False)
padding = [0, 0]
stride = [0, 0]
dilation = [0, 0]
groups = 0
torch.mkldnn_convolution(self, weight, bias, padding, stride, dilation, groups)

Result

floating point exception

Expected behavior

Graceful termination or a RuntimeError to be thrown.

Note

This bug was discovered using fuzz testing.

Versions

PyTorch version: 1.9.0a0+git4d36e60
Is debug build: True
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: Debian GNU/Linux 11 (bullseye) (x86_64)
GCC version: (Debian 10.2.1-6) 10.2.1 20210110
Clang version: 11.0.1-2
CMake version: version 3.22.1
Libc version: glibc-2.31

Python version: 3.9.7 (default, Sep 16 2021, 13:09:58) [GCC 7.5.0] (64-bit runtime)
Python platform: Linux-5.10.0-11-amd64-x86_64-with-glibc2.31
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.22.2
[pip3] torch==1.9.0a0+git4d36e60
[conda] mkl 2022.0.1 h06a4308_117
[conda] mkl-include 2022.0.1 h06a4308_117
[conda] numpy 1.19.5 pypi_0 pypi
[conda] torch 1.9.0a0+git4d36e60 dev_0

cc @ezyang @gchanan @zou3519 @VitalyFedyunin @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh

@VitalyFedyunin VitalyFedyunin added high priority module: error checking triaged labels Feb 26, 2022
@VitalyFedyunin VitalyFedyunin added good first issue module: cpu module: mkldnn and removed triage review labels Feb 26, 2022
@YidaWeng
Copy link

@YidaWeng YidaWeng commented Apr 8, 2022

Can I try to solve this problem?

1 similar comment
@Liquidtoss
Copy link

@Liquidtoss Liquidtoss commented Apr 21, 2022

Can I try to solve this problem?

@XiaobingSuper
Copy link

@XiaobingSuper XiaobingSuper commented Apr 21, 2022

@Liquidtoss, yes, you can.

@Bhavay192
Copy link

@Bhavay192 Bhavay192 commented Apr 22, 2022

@XiaobingSuper , is this issue still open?? Can I resolve this issue?? Thanks

Liquidtoss added a commit to Liquidtoss/pytorch that referenced this issue Apr 24, 2022
Liquidtoss added a commit to Liquidtoss/pytorch that referenced this issue Apr 24, 2022
@Liquidtoss
Copy link

@Liquidtoss Liquidtoss commented Apr 24, 2022

We created a fork, and pushed the changes. Could you look it over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue high priority module: cpu module: error checking module: mkldnn triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants