The Wayback Machine - https://web.archive.org/web/20220523203618/https://github.com/django/django/pull/15581
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YugabyteDB to list of third party DB Backends #15581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sfurti-yb
Copy link

@Sfurti-yb Sfurti-yb commented Apr 12, 2022

YugabyteDB is a Postgres compatible database and has a backend for Django overriding features supported differently in YugbayteDB as compared to Postgres.

We would love to get listed on the list of third party backends on the databases page.

Please let us know in case any changes are required to help us get listed here.

Thanks!

@felixxm
Copy link
Member

@felixxm felixxm commented Apr 12, 2022

@Sfurti-yb I don't see any tests or CI in django-yugabytedb, so we cannot confirm that it actually works or which version of Django it supports.

@github-actions
Copy link

@github-actions github-actions bot commented Apr 12, 2022

Hello @Sfurti-yb! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@Sfurti-yb
Copy link
Author

@Sfurti-yb Sfurti-yb commented Apr 12, 2022

We have run the django test suite to verify that it works. The usage is also documented here to confirm that it works.

** Note- The module name was recently changed from yb_backend to django_yugabytedb which is not yet updated in the doc

@felixxm
Copy link
Member

@felixxm felixxm commented Apr 12, 2022

We have run the django test suite to verify that it works. The usage is also documented here to confirm that it works.

But we cannot verify this without testing it manually. Moreover, in the future, we will not be able to easily check if it supports the latest versions of Django. Please, first set up CI in django-yugabytedb with all supported versions of Django.

@Sfurti-yb
Copy link
Author

@Sfurti-yb Sfurti-yb commented Apr 12, 2022

Okay, we will setup a CI and give an update here. Thanks!

@Sfurti-yb
Copy link
Author

@Sfurti-yb Sfurti-yb commented May 9, 2022

@felixxm We have added the CI setup, with the migrations and schema test modules as you had mentioned. Please take a look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants