Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Update lsp-tramp-connection #2531
Open
+85
−19
Conversation
Copy the implementation that Michael Albinus suggested when graciously helping people understand why lsp wasn't working over tramp. https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00896.html replacing start-file-process-shell-command with make-process and moving from binary encoding to none. > One disadvantage is, that direct asynch processes work only with the upcoming Tramp 2.5 (that's already in Emacs master), and it works only if the asynchronous process does not require password handling. The latter is true, if your ssh authentication is based on keys, or if you use Tramp's control master arguments (enabled by default).
petr-tik
force-pushed the
petr-tik:tramp_connection_compliant_with_2_5
branch
3 times, most recently
from
97052ae
to
24210cb
In the author's experience, tramp 2.5.0-pre worked fine with old and new implementation of lsp-tramp-connection. From the bug reports, reddit messages and other information, it looked like emacs27.1 + tramp >2.5.0-pre works fine Added a Troubleshooting section to the remote doc with examples of the errors. Suggested solution and tips to debug other remote LSP errors.
petr-tik
force-pushed the
petr-tik:tramp_connection_compliant_with_2_5
branch
from
24210cb
to
fe45fe9
|
Looks good. |
| (defvar tramp-connection-properties) | ||
| (when (version< "2.5.0-pre" tramp-version) | ||
| (lsp-warn | ||
| "Your tramp version - %s - might fail to work with remote LSP. Update to tramp-2.5 for tested reliability improvements" |
yyoncho
Jan 17, 2021
Member
can you change the wording to mention that you can install that version from elpa?
can you change the wording to mention that you can install that version from elpa?
| ;; wrap with stty to disable converting \r to \n | ||
| (let* ((final-command (lsp-resolve-final-function | ||
| local-command)) | ||
| (_stderr (or (when generate-error-file-fn |
yyoncho
Jan 17, 2021
Member
this should be appended to the command. Otherwise, the stderr will end up on stdout. (Unless this is fixed in the latest tramp).
this should be appended to the command. Otherwise, the stderr will end up on stdout. (Unless this is fixed in the latest tramp).
petr-tik
Jan 17, 2021
Author
what do you mean by this here?
what do you mean by this here?
yyoncho
Jan 18, 2021
Member
_stderr
_stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Copy the implementation that Michael Albinus suggested when
graciously helping people understand why lsp wasn't working over tramp.
https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00896.html
This replaces start-file-process-shell-command with make-process
and moving from binary encoding to none.
Added a Troubleshooting section to the remote doc with examples
of the errors. Suggested solution and tips to debug other
remote LSP errors.