The Wayback Machine - https://web.archive.org/web/20220517151219/https://github.com/RustPython/RustPython/issues/3637
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Rename derive macro to py:: prefixed #3637

Open
youknowone opened this issue Apr 18, 2022 · 3 comments
Open

[RFC] Rename derive macro to py:: prefixed #3637

youknowone opened this issue Apr 18, 2022 · 3 comments
Labels

Comments

@youknowone
Copy link
Member

@youknowone youknowone commented Apr 18, 2022

Summary

  • #[pyclass] => #[py::class]
  • #[pyimpl] => #[py::class] // I think we can distinguish this from macro
  • #[pyattr] => #[py::attr]
  • #[pyfunction] => #[py::function]
  • #[pyslot] => #[py::slot]
  • #[pymethod] => #[py::method]
  • #[pyproperty] => #[py::property]

Detailed Explanation

Drawbacks, Rationale, and Alternatives

Unresolved Questions

@youknowone youknowone added the RFC label Apr 18, 2022
@coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Apr 19, 2022

How would rustfmt deal with the colon?

@youknowone youknowone changed the title [RFC] Rename derive macro to py: prefixed [RFC] Rename derive macro to py:: prefixed Apr 19, 2022
@youknowone
Copy link
Member Author

@youknowone youknowone commented Apr 19, 2022

I added another colon to negotiate with rustfmt

@youknowone
Copy link
Member Author

@youknowone youknowone commented Apr 29, 2022

@coolreader18 I hope we can do this before next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants