FIX add n_targets allowing consistent shape prediction before calling fit in GPR
#23099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @glemaitre, could you help take a look at this PR, thank you |
glemaitre
reviewed
Jun 22, 2022
glemaitre
changed the title
n_targets for GPRn_targets allowing consistent shape prediction before calling fit in GPR
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added
the
Waiting for Second Reviewer
thomasjpfan
reviewed
Jan 18, 2023
| :meth:`sample_y` before :meth:`fit`). This parameter is ignored once | ||
| :meth:`fit` has been called. |
There was a problem hiding this comment.
API-wise, ignoring n_targets after fit is strange to me.
@glemaitre Assuming n_targets is set, what do you think of requiring the number of targets seen in fit to be consistent with n_targets?
There was a problem hiding this comment.
This is less lenient and more conservative but I don't have any objection to that.
@MaxwellLZH Do you want to make this change of behaviour?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reference Issues/PRs
This PR adds a new argument
n_targetsforGaussianProcessRegressoras suggested in issue #22430 , which will be used to determine the output shape of bothpredictandsample_y, so the shape will be consistent before and after callingfitmethod.Any other comments?
I'm not sure if we should raise error during the fit process if the dimension of
ydoes not matchn_targets, since once we fit the model the output shape will be determined by the shape of y.