Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
PHP short tag check #771
PHP short tag check #771
Comments
Hi @johnwc, no it doesn't. Feel free to propose a pull-request for this. |
@kylekatarnls I see this is marked "Good first issue" though I'm having trouble finding any metric or even getting a custom rule's Any other info or pointers on how to begin would be appreciated. |
Hello, Indeed, PDepend needs to support it first. It contains a src/main/php/PDepend/Source/Language/PHP/PHPTokenizerInternal.php file who run
And it contains: $source = preg_replace(
array('(<\?=)', '(<\?(\s))'),
array('<?php echo ', '<?php\1'),
$source
); This replacement (which is not really needed) should be removed so we can detect each token in src/main/php/PDepend/Source/Language/PHP/AbstractPHPParser.php in the In the switch |
@kylekatarnls I've prepared pdepend/pdepend#490 though not sure where the docs are within that repo in order to update them. Do you have any insight on where I should look? |
Does PHPMD have a check for php files that are using short tag form? <? instead of <?php