The Wayback Machine - https://web.archive.org/web/20211115030529/https://github.com/go-gitea/gitea/pull/14653
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Stars config option #14653

Merged
merged 14 commits into from Apr 15, 2021
Merged

Disable Stars config option #14653

merged 14 commits into from Apr 15, 2021

Conversation

Reviewers

@zeripath zeripath

@noerw noerw

@6543 6543

Assignees
No one assigned
Labels
kind/feature lgtm/done
Milestone
1.15.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@kdumontnu @6543 @codecov-io @zeripath @techknowlogick @noerw @GiteaBot
@kdumontnu
Copy link
Contributor

@kdumontnu kdumontnu commented Feb 11, 2021

If DISABLE_STARS = true remove the option to star repositories

image

The "Starred Repositories" tab in user profile is replaced with "Watched Repositories"
image

This is helpful for enterprise/private accounts where the ability to "star" repositories is not very useful and creates confusion compared to "watching".

Note: I'm working on a separate PR to toggle Watch status in the Profile repo list
@6543
Copy link
Member

@6543 6543 commented Feb 11, 2021

I think the "watching repos" is a nice func anyway :) ... just if we going to add it, can we add a prifacy opt-out add too?

like it exist for Hide the activity from the profile page

Loading

@6543 6543 added this to the 1.15.0 milestone Feb 11, 2021
@kdumontnu
Copy link
Contributor Author

@kdumontnu kdumontnu commented Feb 11, 2021

I think the "watching repos" is a nice func anyway :) ... just if we going to add it, can we add a prifacy opt-out add too?

like it exist for Hide the activity from the profile page

I used the same settings as "Starred Repositories". Should that be hidden as well? The setting is also ignored for Repositories, Following, and Followed. This seems like a separate PR, but I'm happy to open one to fix that.

Loading

@techknowlogick techknowlogick changed the title Kd/conf disable stars Disable Stars config option Feb 11, 2021
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 14, 2021 •
edited
Loading

Codecov Report

Merging #14653 (2638218) into master (487f2ee) will decrease coverage by 0.00%.
The diff coverage is 34.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14653      +/-   ##
==========================================
- Coverage   42.21%   42.21%   -0.01%     
==========================================
  Files         767      767              
  Lines       81624    81652      +28     
==========================================
+ Hits        34458    34468      +10     
- Misses      41531    41547      +16     
- Partials     5635     5637       +2
Impacted Files Coverage Δ
models/repo_list.go 77.19% <0.00%> (-1.57%) ⬇️
modules/setting/repository.go 57.69% <ø> (ø)
modules/structs/issue.go 0.00% <ø> (ø)
routers/user/profile.go 43.24% <0.00%> (-4.05%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.22% <50.00%> (+1.37%) ⬆️
modules/context/context.go 58.61% <100.00%> (+0.10%) ⬆️
modules/setting/setting.go 49.03% <100.00%> (ø)
modules/templates/base.go 42.30% <100.00%> (+1.13%) ⬆️
routers/api/v1/settings/settings.go 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f05a28...8bf3a61. Read the comment docs.

Loading

@kdumontnu
Copy link
Contributor Author

@kdumontnu kdumontnu commented Feb 16, 2021

@6543 did you still want me to make the change to put this behind the KeepActivityPrivate flag?
It appears right now this flag is only checked for the Activity tab, not Repositories, Stars, Following, or Followed.
I'm happy to make the change, but honestly I think it's better to do in a separate PR to address all cases.

Loading

@6543
Copy link
Member

@6543 6543 commented Feb 16, 2021

@kdumontnu I think we can seperate it ...

Loading

@kdumontnu kdumontnu force-pushed the kd/conf_disable_stars branch from 2638218 to 89c84a7 Feb 16, 2021
noerw
noerw approved these changes Feb 20, 2021
View changes
kdumontnu added 2 commits Feb 20, 2021
@kdumontnu
Add config option to disable stars
9d184f1
@kdumontnu
Replace "stars" with watched in user profile
882a236
@kdumontnu kdumontnu force-pushed the kd/conf_disable_stars branch from 8bf3a61 to 53f8d2b Feb 20, 2021
@kdumontnu
Add documentation
842ed0f
@kdumontnu kdumontnu force-pushed the kd/conf_disable_stars branch from 53f8d2b to 842ed0f Feb 21, 2021
@6543
Copy link
Member

@6543 6543 commented Feb 21, 2021

@kdumontnu sorry that it wont get reviewed and merged right away... just for you as an info: gitea is in feature freeze at the moment ...

Loading

@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
50adeb0
@kdumontnu kdumontnu force-pushed the kd/conf_disable_stars branch from af2360c to 50adeb0 Feb 22, 2021
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
d5d3bc3
@zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 25, 2021

OK I think this looks fine - I don't quite understand why the feature needs disabling but the PR does do everything needed to disable the feature completely.

Loading

kdumontnu added 2 commits Feb 25, 2021
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
d52cd5b
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
0d1eacf
@kdumontnu
Copy link
Contributor Author

@kdumontnu kdumontnu commented Mar 1, 2021

OK I think this looks fine - I don't quite understand why the feature needs disabling but the PR does do everything needed to disable the feature completely.

Excellent! I understand the hesitation, but generally speaking for private projects "stars" provide very little value and can add unnecessary complexity for users.

Loading

@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
e69f838
kdumontnu added 4 commits Mar 2, 2021
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
40d0455
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
34c1287
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
881acdf
@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
d200175
@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Mar 11, 2021

@kdumontnu just reaching out to you here to let you know I sent a PM to your discord, hoping you saw it :)

Loading

@zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 15, 2021

Please resolve conflicts

Loading

@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
3cf9491
6543
6543 approved these changes Apr 15, 2021
View changes
@6543
Copy link
Member

@6543 6543 commented Apr 15, 2021

@kdumontnu can you "update branch" please?

Loading

@kdumontnu
Merge branch 'master' into kd/conf_disable_stars
0216c25
@6543
Copy link
Member

@6543 6543 commented Apr 15, 2021

🚀

Loading

@6543 6543 merged commit f44543a into go-gitea:master Apr 15, 2021
2 checks passed
Loading
@kdumontnu kdumontnu deleted the kd/conf_disable_stars branch May 3, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.