The Wayback Machine - https://web.archive.org/web/20220503114028/https://github.com/go-gitea/gitea/pull/14789
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DefaultMergeStyle option to repository #14789

Merged
merged 13 commits into from Mar 27, 2021

Conversation

Copy link
Contributor

@parnic parnic commented Feb 24, 2021

This pull request adds support for configuring the default merge style for pull requests in a repository.

Fixes #12293

Note: I haven't added tests or anything yet, mostly because I wanted to make sure this was

  1. Something you all are willing to merge at all
  2. Meets contribution guidelines/requirements.

@6543 6543 added this to the 1.15.0 milestone Feb 24, 2021
parnic added 3 commits Feb 24, 2021
This was originally based on the 1.13.2 branch, but it seems this has changed in master
There's no real need for this as the default handles a missing setting.
@lunny
Copy link

@lunny lunny commented Feb 25, 2021

DefaultMergeStyle should be selected on pull request view merge dropdown button.

@parnic
Copy link
Author

@parnic parnic commented Feb 25, 2021

DefaultMergeStyle should be selected on pull request view merge dropdown button.

@lunny do you mean templates/repo/issue/view_content/pull.tmpl? If so, that's what the routers/repo/issue.go change is accomplishing. If not, where do you mean?

lunny
lunny approved these changes Mar 4, 2021
@pat-s
Copy link

@pat-s pat-s commented Mar 17, 2021

@parnic Could you resolve the merge conflicts? :) there are already two approvals.

@6543
Copy link

@6543 6543 commented Mar 27, 2021

🚀

@6543 6543 merged commit f4d2749 into go-gitea:master Mar 27, 2021
2 checks passed
@parnic parnic deleted the add-default-merge-style branch Mar 27, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

8 participants