The Wayback Machine - https://web.archive.org/web/20220503185705/https://github.com/go-gitea/gitea/pull/15501
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing icons and colorpicker when mounted on suburl #15501

Merged
merged 3 commits into from Apr 15, 2021

Conversation

Copy link
Contributor

@zeripath zeripath commented Apr 15, 2021

icons and colorpicker are missing when mounted on a suburl. This PR fixes this.

Signed-off-by: Andrew Thornton [email protected]

webpack.config.js Outdated Show resolved Hide resolved
@go-gitea go-gitea deleted a comment from zeripath Apr 15, 2021
webpack.config.js Outdated Show resolved Hide resolved
@zeripath
Copy link
Author

@zeripath zeripath commented Apr 15, 2021

The global flag is necessary

From try.gitea.io/index.css unminified:

@font-face {
    font-family: Icons;
    src: url(themes/default/assets/fonts/icons.eot);
    src: url(themes/default/assets/fonts/icons.eot?#iefix) format("embedded-opentype"),url(/fonts/icons.woff2) format("woff2"),url(themes/default/assets/fonts/icons.woff) format("woff"),url(themes/default/assets/fonts/icons.ttf) format("truetype"),url(themes/default/assets/fonts/icons.svg#icons) format("svg");
    font-style: normal;
    font-weight: 400;
    font-variant: normal;
    text-decoration:inherit;text-transform:none}

I think we even need to do the eot ones too

@silverwind
Copy link

@silverwind silverwind commented Apr 15, 2021

I think we even need to do the eot ones too

Modern browsers (e.g. those we support) should not hit on EOT/SVG fonts but prefer WOFF.

The global flag is necessary

Why? global flag is pointless for simple regex.test which I think is what webpack would perform. It does not matter if there is more than 1 match.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Copy link
Author

@zeripath zeripath commented Apr 15, 2021

you're right. Strangely I was sure that the g did the thing I wanted it to do.

Sorry.

@lafriks lafriks merged commit 6a7090b into go-gitea:master Apr 15, 2021
1 of 2 checks passed
@lafriks
Copy link

@lafriks lafriks commented Apr 15, 2021

please send backport

@zeripath zeripath deleted the icons-missing-on-suburl branch Apr 16, 2021
@zeripath
Copy link
Author

@zeripath zeripath commented Apr 16, 2021

I don't think this actually does need a backport

@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants