The Wayback Machine - https://web.archive.org/web/20220503002151/https://github.com/go-gitea/gitea/pull/14866
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add dashboard milestone search and repo milestone search by name. #14866

Merged
merged 16 commits into from Apr 8, 2021
Merged

Feat: Add dashboard milestone search and repo milestone search by name. #14866

merged 16 commits into from Apr 8, 2021

Conversation

rogerluo410
Copy link
Contributor

@rogerluo410 rogerluo410 commented Mar 3, 2021 •
edited by 6543

Feature for issue 13845:

  • Add milestones search by name on dashboard milestones page.
  • Add milestones search by name on repo issue/milestones page.

Two features merged to one PR.

Origin PR:
#14806

Issue link:
#13845

close #13845

@rogerluo410 rogerluo410 mentioned this pull request Mar 3, 2021
Closed
1 task
@noerw noerw added this to the 1.15.0 milestone Mar 3, 2021
zeripath
zeripath reviewed Mar 3, 2021
View changes
models/issue_milestone.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Mar 3, 2021
View changes
models/issue_milestone.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Mar 3, 2021
View changes
models/issue_milestone.go Outdated Show resolved Hide resolved
@zeripath
Copy link

@zeripath zeripath commented Mar 3, 2021

you need to run go fmt on these files too.

noerw
noerw approved these changes Mar 8, 2021
View changes
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 13, 2021

Codecov Report

Merging #14866 (0c29954) into master (487f2ee) will decrease coverage by 0.09%.
The diff coverage is 41.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14866      +/-   ##
==========================================
- Coverage   42.21%   42.11%   -0.10%     
==========================================
  Files         767      774       +7     
  Lines       81624    83045    +1421     
==========================================
+ Hits        34458    34977     +519     
- Misses      41531    42385     +854     
- Partials     5635     5683      +48
Impacted Files Coverage Δ
cmd/dump.go 0.93% <0.00%> (-0.01%) ⬇️
cmd/serv.go 2.61% <0.00%> (-0.02%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
cmd/web_graceful.go 0.00% <0.00%> (ø)
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v130.go 0.00% <0.00%> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc64704...0c29954. Read the comment docs.

@6543
Copy link

@6543 6543 commented Apr 8, 2021

🚀

@6543 6543 merged commit fa06e98 into go-gitea:master Apr 8, 2021
2 checks passed
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath

@noerw noerw

Assignees
No one assigned
Labels
kind/feature lgtm/done
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Search box on Milestones page
6 participants
@rogerluo410 @zeripath @codecov-io @6543 @noerw @GiteaBot