Call MultipartForm.RemoveAll when request finishes #19606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
May 5, 2022
lunny
approved these changes
May 5, 2022
|
|
6543
pushed a commit
that referenced
this issue
May 5, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this issue
May 5, 2022
* giteaofficial/main: Call MultipartForm.RemoveAll when request finishes (go-gitea#19606) Remove `RequireHighlightJS` field, update plantuml example. (go-gitea#19615) [skip ci] Updated translations via Crowdin PullService lock via pullID (go-gitea#19520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix #19595
Golang's
mime/multipart/formdata.gocaches files on disk, these temp files should be removed by caller when request finishes if we cloned the http.RequestTested and work as expected