Allow oauth2 application redirect_uris to contain wildcards #19627
+70
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Currently, Gitea matches the redirect URI for oauth2 authorize requests against a static list of valid URIs. This causes problems for applications like Gitea-based comments engine Vssue that set the redirect URI to the current page to ensure the user gets redirected to the correct post.
This change introduces a setting called
ENABLE_REDIRECT_URI_WILDCARDwhich, when enabled, causes Gitea to check a redirect URI against the list of allowed URIs using wildcard matching.Example:
http://localhost:4000/blog/post.htmlis valid if the URI ishttp://localhost:4000/blog/*The implementation works by transforming the pattern into a regular expression (e.g.
http://localhost:4000/blog/.*) and matching the redirect URI against that expression.This new setting is disabled by default, which preserves the existing behavior. Closes #9514.