The Wayback Machine - https://web.archive.org/web/20201009013220/https://github.com/keon/algorithms/pull/513
Skip to content

/ algorithms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI: Drop the EOL Python 3.4 and add 3.7 #513

Merged
merged 3 commits into from Jul 29, 2019
Merged

Travis CI: Drop the EOL Python 3.4 and add 3.7 #513

merged 3 commits into from Jul 29, 2019

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 25, 2019

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #[issue number] if related to any issue

  • other
cclauss added 2 commits Jul 25, 2019
@cclauss
Travis CI: Drop the EOL Python 3.4 and add 3.7
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
50058d7
@cclauss
Tox.ini: Travis CI: Drop the EOL py34
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
be444a6
@coveralls
Copy link

@coveralls coveralls commented Jul 25, 2019 •
edited

Pull Request Test Coverage Report for Build 929

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 75.604%
Files with Coverage Reduction New Missed Lines %
algorithms/sort/top_sort.py 2 90.38%
Totals Coverage Status
Change from base Build 928: -0.03%
Covered Lines: 5978
Relevant Lines: 7907
💛 - Coveralls
@goswami-rahul
goswami-rahul approved these changes Jul 29, 2019
View changes
Copy link
Collaborator

@goswami-rahul goswami-rahul left a comment

LGTM. Thanks for the PR.
@goswami-rahul
Merge branch 'master' into patch-2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9008498
@goswami-rahul goswami-rahul merged commit 44298eb into keon:master Jul 29, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.03%) to 75.604%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cclauss cclauss deleted the cclauss:patch-2 branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goswami-rahul goswami-rahul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cclauss @coveralls @goswami-rahul
You can’t perform that action at this time.