The Wayback Machine - https://web.archive.org/web/20201105160407/https://github.com/Tivix/django-rest-auth/pull/566
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return login data from SocialLoginSerializer.validate for views to use #566

Open
wants to merge 1 commit into
base: master
from

Conversation

@lukeburden
Copy link

@lukeburden lukeburden commented Aug 21, 2019

I needed to customize SocialConnectView, such that in its response it renders the SocialAccount newly created or updated. Since this library persists the new SocialAccount instance in the call to SocialLoginSerializer.validate, this meant returning the social login in the validated attributes, such that a custom connect view could then render the new account using SocialAccountSerializer.

This is a small change allowing that kind of flexibility.

@coveralls
Copy link

@coveralls coveralls commented Aug 21, 2019

Coverage Status

Coverage increased (+0.004%) to 96.048% when pulling f51ebbe on livebungalow:return-login-data-from-validate into 624ad01 on Tivix:master.

@BarnabasSzabolcs
Copy link

@BarnabasSzabolcs BarnabasSzabolcs commented May 30, 2020

Hi,
as a user of rest-auth, thanks for the contribution!
This repo is not maintained anymore, so the development moved to dj-rest-auth. (reference: #568)
It may be best, if you move this PR there. (and upgrade to using dj_rest_auth)

new repo link: https://github.com/jazzband/dj-rest-auth (I'm not the upkeeper of that repo, it just makes sense for me to help you merge your PR)

Many Thanks,
Barney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.