The Wayback Machine - https://web.archive.org/web/20220530091425/https://github.com/rclone/rclone/pull/6129
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jottacloud: Fix listing output of remote with special characters #6129

Merged
merged 1 commit into from May 12, 2022
Merged

Jottacloud: Fix listing output of remote with special characters #6129

merged 1 commit into from May 12, 2022

Conversation

albertony
Copy link
Contributor

@albertony albertony commented Apr 27, 2022 •
edited

What is the purpose of this change?

This fixes the failing integration test: TestIntegration/FsMkdir/FsPutFiles/FsIsFile

Previously there was a discrepancy:

rclone ls "remote:Archive/rclone-test-tozewob2qibivak0cucuxip9/hello? sausage/êé/Hello, 世界/ \" abc"
        0 Archive/Archive/rclone-test-tozewob2qibivak0cucuxip9/hello? sausage/êé/Hello, 世界/ " abc/z.txt

rclone ls "remote:Archive/rclone-test-tozewob2qibivak0cucuxip9/hello? sausage/êé/Hello, 世界/ \" abc" --disable ListR
        0 z.txt

The latter is correct, and with this fix both returns this result.

Was the change discussed in an issue or in the forum before?

No. Detected by integration test TestIntegration/FsMkdir/FsPutFiles/FsIsFile.

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

@albertony albertony self-assigned this Apr 27, 2022
@albertony
jottacloud: fix listing output of remote with special characters
644ca48 
This fixes the failing integration test: TestIntegration/FsMkdir/FsPutFiles/FsIsFile
@albertony albertony force-pushed the jotta-listr-encoding-fix branch from b64241b to 644ca48 Compare Apr 27, 2022
ncw
ncw approved these changes May 12, 2022
View changes
Copy link
Member

@ncw ncw left a comment

Thank you :-)

I'll merge this.

I fixed the integration tests, so hopefully we'll see the result tomorrow some time at

https://pub.rclone.org/integration-tests/current/

@ncw ncw merged commit a9d3283 into rclone:master May 12, 2022
10 checks passed
@albertony albertony deleted the jotta-listr-encoding-fix branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw

Assignees

@albertony albertony

Labels
bug Remote: Jottacloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertony @ncw