storj: fix put #6152
Merged
storj: fix put #6152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "relative" argument was missing when Put'ing a file. This sets an incorrect object entry in the cache, leading to the file being unreadable when using mount functionality. Fixes #6151
|
I'll investigate which integration test I should extend. |
It's difficult to create a test because the tests are run inside a bucket ( (Another reason this might not be caught could be because the test uses So for now I offer this change as-is without any regression test. |
|
Thank you for the explanation. I'll run the CI and merge if successful :-) |
ncw
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The "relative" argument was missing when Put'ing a file. This
sets an incorrect object entry in the cache, leading to the file being
unreadable when using mount functionality.
Fixes #6151 and doesn't seem to break any other functionality.
Checklist