The Wayback Machine - https://web.archive.org/web/20220427140456/https://github.com/pandas-dev/pandas/issues/46865
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE replace flake8-rst with something maintained #46865

Open
MarcoGorelli opened this issue Apr 25, 2022 · 0 comments
Open

STYLE replace flake8-rst with something maintained #46865

MarcoGorelli opened this issue Apr 25, 2022 · 0 comments
Labels
Code Style good first issue

Comments

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Apr 25, 2022

Currently, we use flake8-rst for running flake8 in code snippets in rst files:

- id: flake8-rst
name: flake8-rst
description: Run flake8 on code snippets in docstrings or RST files
language: python
entry: flake8-rst
types: [rst]
args: [--filename=*.rst]
additional_dependencies: [flake8-rst==0.7.0, flake8==3.7.9]

However, flake8-rst isn't maintained, and is currently run in its own environment with a different flake8 version because of incompatibilities with flake8 v4

Task here is:

  • search around to see if there's a maintained tool which does the same thing (runs flake8 on code snippets in rst files)
  • try using that instead, fixup any new errors which may result from running it via pre-commit on all files
  • make a PR
@MarcoGorelli MarcoGorelli added Code Style good first issue labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style good first issue
Projects
None yet
Development

No branches or pull requests

1 participant