add Go edition variants #948
Conversation
In some cases, if the script was run with sh or bash (instead of ./) TOP couldn't be set correctly
tenzap
force-pushed
the
f_go_edition
branch
12 times, most recently
from
b37ac53
to
6c7513c
Compare
On pie emulator system-image, GmsCore is stored in priv-app/PrebuiltGmsCore and not in priv-app/PrebuiltGmsCorePi so remove this too
|
Thanks, sorry that I didn't take a look earlier yet. But I will need some time to review |
Thanks for your big PR to set-up the Go-packages.
Did you do extensive testing on these changes? It are quite a lot of changes, so it is good to make sure
I don't know what you mean by extended, but I tested it with lineageos & google system images using emulated device with this script that works from android 8 up to android 12. |
|
Thanks for all the testing, if you can fix that bashism I will merge it! |
|
Could you rebase on current master to resolve the conflict? |
|
I don't see any conflict. I solved it in 6c6b593 |
|
After merge, you may also consider #949 |
|
Github still mentions the conflict, can you rebase on 897620f ? |
|
|
|
That is so weird, I have "This branch cannot be rebased due to conflicts". |
|
Ok. Thanks again for merging. |
Comments are welcome.
To add packages, new google certificates need to be added to the opengapps keystore #949
Go variants are suffixed with "_go" (except super which contains in itself the go packages).
For example
bash build_gapps.sh arm 31 pico_go