The Wayback Machine - https://web.archive.org/web/20220603043946/https://github.com/opengapps/opengapps/pull/959
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 12 build support. #959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Android 12 build support. #959

wants to merge 1 commit into from

Conversation

ipdev99
Copy link
Contributor

@ipdev99 ipdev99 commented May 11, 2022

Android 12 and 12L build support.

Change in the installer script is cosmetic.
Since both 12 and 12L use ro.build.version.release=12
This will display SDK32 as 12L instead of 12.

Include Android 12 (SDK31) and Android 12L (SDK32)
@ipdev99
Copy link
Contributor Author

@ipdev99 ipdev99 commented May 11, 2022

Since Android 9 (SDK28) Google stopped incremental builds.
I could not find the article (might have been a page that Google changed/deleted/updated).
I may have missed bringing back incremental builds. 🙃

Starting from SDK 28, each new API/SDK level would be a new release level.
Until 12L 🙃

The build branch was updated to 12.1 when 12L was released but..

Platform codenames, versions, API levels, and NDK releases - source.android - has been updated a few times.
When I started on 12L builds, it was not listed. Then it was listed as Android 12L when release.
Now listed as version 12.1

Android 12 (31) and 12L (32) still share the 12 release tag.
12L still shows (May 2022 factory Pixel releases) as 12, not 12.1 or 12L

I am not sure how to name it. 🤔
Stay with 12 and 12L or switch to 12.0 and 12.1

Cheers all. 🤠

@flame-0
Copy link

@flame-0 flame-0 commented May 14, 2022

I am wondering if I can use this now?

@josephcsible
Copy link
Contributor

@josephcsible josephcsible commented May 14, 2022

@mfonville
Copy link
Member

@mfonville mfonville commented May 29, 2022

Thanks for your PR!

@nezorflame would the updated naming scheme with 12 and 12L work well with our website API for downloads?

@nezorflame
Copy link
Contributor

@nezorflame nezorflame commented Jun 2, 2022

Thanks, I'll check this.

@nezorflame nezorflame requested review from nezorflame and mfonville Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants