The Wayback Machine - https://web.archive.org/web/20250520193255/https://github.com/vuejs/vue/pull/12376
Skip to content

fix #12374: do not hyphenate or omit CSS variables in style attribute #12376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

fieteboerner
Copy link

@fieteboerner fieteboerner commented Dec 5, 2021

close #12374

This PR adds a specific test for CSS variables and solves the issue. So it behaves the same as the vue browser renderer.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link

@abdih abdih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from these minor comments, the change LGTM. Thank you for making it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vue-server-renderer: CSS variables get lost in dynamic style attributes
2 participants