The Wayback Machine - https://web.archive.org/web/20220319151324/https://github.com/slackapi/node-slack-sdk/issues/852
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov reports should use fully qualified filenames #852

Open
3 tasks done
aoberoi opened this issue Aug 20, 2019 · 2 comments
Open
3 tasks done

Codecov reports should use fully qualified filenames #852

aoberoi opened this issue Aug 20, 2019 · 2 comments

Comments

@aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Aug 20, 2019

Description

Currently when Codecov collects/aggregates coverage reports for a specific change, the reports from several packages collide in a way that makes the aggregations incorrect. For example, both the @slack/web-api and @slack/webhoook packages include a file called src/errors.ts. For Codecov, these are the same file.

There is a separate, but potentially related problem that sometimes the commit SHA that Travis prints out after the coverage report upload does not match the commit SHA from the branch (pull request). When this happens, the PR on GitHub will never receive a status check result. Upon re-running the build, it sometimes will match, and then Codecov's status check will be present.

Related: #851

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the tests label Aug 20, 2019
@seratch
Copy link
Member

@seratch seratch commented Mar 22, 2021

This issue seems to be still relevant. https://codecov.io/gh/slackapi/node-slack-sdk/tree/main/src

@github-actions
Copy link

@github-actions github-actions bot commented Dec 5, 2021

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants