[feat] |important modifier for style directive
#7489
Merged
+153
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welp, at least all of that is passing @tanhauhau The other PR was marked as draft, was that because of the runtime test being weird or some other reason? |
gtm-nayan
force-pushed
the
gh-7365
branch
2 times, most recently
from
9ee8604
to
ca158da
Compare
tanhauhau
approved these changes
May 29, 2022
4 tasks
tanhauhau
approved these changes
Jun 17, 2022
baseballyama
reviewed
Jun 29, 2022
test/runtime-puppeteer/samples/inline-style-directive-important/main.svelte
Outdated
Show resolved
Hide resolved
third param for set_style is optional
Runtime test doesn't work because of weird behaviour of computed style the puppeteer test should cover it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Alt syntax for #7470 as per #7365 (comment)
Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lintTODO:
'style:background-color|important' is not a valid attribute nameerror, compiler problem or just language tools using the released version of svelte for diagnosis?