The Wayback Machine - https://web.archive.org/web/20220610050237/https://github.com/angular/angular/pull/46280
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): allow null in ngComponentOutlet #46280

Closed
wants to merge 1 commit into from
Closed

fix(common): allow null in ngComponentOutlet #46280

wants to merge 1 commit into from
+2 −2

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 7, 2022

ngComponentOutlet already handles null/undefined values, but the types don't reflect that. These changes update the types.

Fixes #45716.

@crisbeto crisbeto added action: review comp: common target: patch labels Jun 7, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 7, 2022
@pullapprove pullapprove bot requested review from atscott Jun 7, 2022
@crisbeto crisbeto force-pushed the 45716/comp-outlet-null branch from 120766c to 72f4b38 Compare Jun 7, 2022
pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 7, 2022
View changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@crisbeto
fix(common): allow null in ngComponentOutlet
0c5cf63 
`ngComponentOutlet` already handles null/undefined values, but the types don't reflect that. These changes update the types.

Fixes angular#45716.
@crisbeto crisbeto force-pushed the 45716/comp-outlet-null branch from 72f4b38 to 0c5cf63 Compare Jun 7, 2022
AndrewKushnir
AndrewKushnir approved these changes Jun 7, 2022
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Thanks for the update @crisbeto 👍

@pullapprove pullapprove bot requested review from alxhub and jessicajaniuk Jun 7, 2022
AndrewKushnir
AndrewKushnir approved these changes Jun 7, 2022
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: public-api

atscott
atscott approved these changes Jun 7, 2022
View changes
Copy link
Contributor

@atscott atscott left a comment

reviewed-for: public-api

jessicajaniuk
jessicajaniuk approved these changes Jun 7, 2022
View changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

reviewed-for: public-api

alxhub
alxhub approved these changes Jun 8, 2022
View changes
atscott
atscott approved these changes Jun 9, 2022
View changes
@jessicajaniuk jessicajaniuk added the action: merge label Jun 9, 2022
@jessicajaniuk jessicajaniuk removed the request for review from atscott Jun 9, 2022
@jessicajaniuk
Copy link
Contributor

@jessicajaniuk jessicajaniuk commented Jun 9, 2022

This PR was merged into the repository by commit 8b9c32d.

jessicajaniuk pushed a commit that referenced this issue Jun 9, 2022
@crisbeto @jessicajaniuk
fix(common): allow null in ngComponentOutlet (#46280)
ef5cba3 
`ngComponentOutlet` already handles null/undefined values, but the types don't reflect that. These changes update the types.

Fixes #45716.

PR Close #46280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott

@pkozlowski-opensource pkozlowski-opensource

@alxhub alxhub

@AndrewKushnir AndrewKushnir

@jessicajaniuk jessicajaniuk

Assignees
No one assigned
Labels
action: merge comp: common target: patch
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

*ngComponentOutlet types don't allow null/undefined, even though it supports it
6 participants
@crisbeto @jessicajaniuk @atscott @pkozlowski-opensource @alxhub @AndrewKushnir