ci: fix stamping for builds performed in CI #45147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like another reason for the incorrect stamp comes is: angular/dev-infra#416 |
Fixes the stamping for snapshot builds and the artifact deployment job. Currently the stamped versions will have the `.with-local-changes` version suffix given that we add a file to the Git repo that is just needed for the CircleCI cache key computation.
devversion
force-pushed
the
ci/fix-snapshot-stamping-ci
branch
from
7c71ffa
to
0a40799
Compare
devversion
added
action: review
target: patch
jessicajaniuk
added
the
comp: build & ci
gkalpak
approved these changes
Feb 25, 2022
devversion
added
action: merge
|
This PR was merged into the repository by commit e56472d. |
jessicajaniuk
pushed a commit
that referenced
this issue
Feb 25, 2022
Fixes the stamping for snapshot builds and the artifact deployment job. Currently the stamped versions will have the `.with-local-changes` version suffix given that we add a file to the Git repo that is just needed for the CircleCI cache key computation. PR Close #45147
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes the stamping for snapshot builds and the artifact deployment job.
Currently the stamped versions will have the
.with-local-changesversionsuffix given that we add a file to the Git repo that is just
needed for the CircleCI cache key computation.