feat(react): add setupIonicReact function #24254
Merged
+60
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #24139
With the Custom Elements build, we now need to call
initialize()
: https://github.com/ionic-team/ionic-framework/blob/next/packages/react/src/components/index.ts#L202. The problem is that this call also sets up the Ionic config. Given that Ionic config is not designed to be reactive, subsequent calls tosetupConfig
had no effect.What is the new behavior?
setupIonicReact
to theirApp.tsx
/App.jsx
file. This function will callinitialize
and allow developers to pass in a config, so it can be used instead ofsetupConfig
.setupConfig
on their own. If they need to eject from the normal process, they should callinitialize
instead.Does this introduce a breaking change?
Other information
Migration:
setupIonicReact
from '@ionic/react';App.tsx
, callsetupIonicReact();
. Config should be passed here instead ofsetupConfig
.setupConfig
.