The Wayback Machine - https://web.archive.org/web/20220525073831/https://github.com/ionic-team/ionic-framework/pull/25043
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playwright): screenshots are now ignored locally #25043

Merged
merged 1 commit into from Apr 1, 2022

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Apr 1, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Screenshot files are not gitignored. This means that users testing screenshots locally can accidentally push screenshots to git. We only want screenshots generated by CI allowed on git.

What is the new behavior?

  • All files in core/**/*-snapshots directories (I.e. the directories that playwright puts screenshots in) are now gitignored
  • the GH actions task that updates screenshots now uses --force when doing git add to ensure that CI generated screenshots are added to the repo.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from as a code owner Apr 1, 2022
@github-actions github-actions bot added the package: core label Apr 1, 2022
@liamdebeasi liamdebeasi force-pushed the playwright-screenshot-ignore branch from d264327 to b90c85f Compare Apr 1, 2022
@github-actions github-actions bot removed the package: core label Apr 1, 2022
@liamdebeasi liamdebeasi merged commit 12fd19d into main Apr 1, 2022
42 checks passed
@liamdebeasi liamdebeasi deleted the playwright-screenshot-ignore branch Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants