The Wayback Machine - https://web.archive.org/web/20220707153119/https://github.com/matplotlib/matplotlib/issues/23176
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc]: Bracket ArrowStyle Angle Unclear #23176

Open
story645 opened this issue Jun 1, 2022 · 8 comments
Open

[Doc]: Bracket ArrowStyle Angle Unclear #23176

story645 opened this issue Jun 1, 2022 · 8 comments
Labels
Documentation Good first issue

Comments

@story645
Copy link
Member

@story645 story645 commented Jun 1, 2022 •
edited

Documentation Link

https://matplotlib.org/devdocs/users/prev_whats_new/whats_new_3.4.0.html?highlight=bracket#angles-on-bracket-arrow-styles

Problem

I can't tell from this figure what Angle = 60 is relative to, since the top angle is >60 and the lower angle is <60 in the first example, and '0 degrees means perpendicular to the line' is buried in the api docs (I missed what that means like 6 times)

image

Suggested improvement

An example, that's cross referenced against the API docs, where the angle is marked up, similar to the scale invariant docs
image

I think it'd be nice to include the formulas for setting the bracket horizontal or vertical relative to the axes, but that's totally extra. I think it's a good first issue since it's completely standalone, a relatively small addition, and this information is missing.
@story645 story645 added Documentation Good first issue labels Jun 1, 2022
@lucasricci
Copy link
Contributor

@lucasricci lucasricci commented Jun 13, 2022

Hello, I would like to work with that issue. However, I think I did not completely understand your idea, it is to draw the angles in the image to make it more clear, like in your sugestion?

@story645
Copy link
Member Author

@story645 story645 commented Jun 13, 2022 •
edited

Exactly, a

  1. new gallery example (this may end up appended to an existing example, but easier if you start it new)
  2. that looks like the bracket example from what's new
  3. where the angle argument is annotated like in the scale invariant angle 171474679-ee821900-35a2-4355-8759-bff6aad1ab63__01.png

@lucasricci
Copy link
Contributor

@lucasricci lucasricci commented Jun 14, 2022

@story645 Something like this?
image

@story645
Copy link
Member Author

@story645 story645 commented Jun 14, 2022

Yup, except the angle is always between the brace and the perpendicular

@lucasricci
Copy link
Contributor

@lucasricci lucasricci commented Jun 14, 2022

I see, but I'm unsure how I would do that with matplotlib

@story645
Copy link
Member Author

@story645 story645 commented Jun 14, 2022

I think by importing the ArcAnnotation class from the scale invariant example (you can cross link in the text) and using that to label the angles. I think the perpendicular can be drawn using either vlines or plot.

@lucasricci
Copy link
Contributor

@lucasricci lucasricci commented Jun 14, 2022

Ok, thanks. I'll see this tomorrow

@lucasricci
Copy link
Contributor

@lucasricci lucasricci commented Jun 15, 2022

I successfully created the lines using vlines() but I can't do the same with Arc()

Figure_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@story645 @lucasricci