[Blazor] Fetch logic should check if the asset is present in the list of included assets before deciding to serve index.html #40678

javiercn · 2022-03-12T09:53:03Z

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/Client/wwwroot/service-worker.published.js

Lines 41 to 59 in 2b4a186

    
           async function onFetch(event) { 
        
               let cachedResponse = null; 
        
               if (event.request.method === 'GET') { 
        
                   // For all navigation requests, try to serve index.html from cache 
        
                   // If you need some URLs to be server-rendered, edit the following check to exclude those URLs 
        
           //#if(IndividualLocalAuth && Hosted) 
        
                   const shouldServeIndexHtml = event.request.mode === 'navigate' 
        
                       && !event.request.url.includes('/connect/') 
        
                       && !event.request.url.includes('/Identity/'); 
        
           //#else 
        
                   const shouldServeIndexHtml = event.request.mode === 'navigate'; 
        
           //#endif 
        
                   const request = shouldServeIndexHtml ? 'index.html' : event.request; 
        
                   const cache = await caches.open(cacheName); 
        
                   cachedResponse = await cache.match(request); 
        
               } 
        
               return cachedResponse || fetch(event.request);

This causes issues when users try to access a resource on the page directly through the address bar.

The proposal involves updating the service worker to make sure that if a request is for an offline resource, we never serve index.html

Something like

const shouldServeIndexHtml = event.request.mode === 'navigate' && !self.assetManifest.assets.some(asset => asset.url === event.request.url)

The text was updated successfully, but these errors were encountered:

msftbot · 2022-03-14T11:00:06Z

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

allprogrammers · 2022-03-28T15:29:03Z

Hello Everyone,

I want to work on this issue. Can it be assigned to me ?

javiercn · 2022-03-28T15:30:03Z

@allprogrammers go for it!

allprogrammers · 2022-03-29T07:31:19Z

Thank you.

I can just copy paste your suggestion but I want to be able to recreate the issue first and see what really the problem is. Can you give some instructions to do that? @javiercn

javiercn added area-blazor blazor-wasm feature-pwa labels Mar 12, 2022

javiercn mentioned this issue Mar 12, 2022

Blazor WASM PWA not returning static files from wwwroot on first request after publish due to service worker cache #39592

Closed

1 task

javiercn added this to the Backlog milestone Mar 14, 2022

javiercn added help wanted good first issue labels Mar 14, 2022

javiercn assigned allprogrammers Mar 28, 2022

Apr	MAY	Jun
	27
2021	2022	2023

dotnet / aspnetcore Public

[Blazor] Fetch logic should check if the asset is present in the list of included assets before deciding to serve index.html #40678

[Blazor] Fetch logic should check if the asset is present in the list of included assets before deciding to serve index.html #40678

javiercn commented Mar 12, 2022 •

edited

msftbot bot commented Mar 14, 2022

allprogrammers commented Mar 28, 2022

javiercn commented Mar 28, 2022

allprogrammers commented Mar 29, 2022 •

edited

dotnet / aspnetcore Public

[Blazor] Fetch logic should check if the asset is present in the list of included assets before deciding to serve index.html #40678

[Blazor] Fetch logic should check if the asset is present in the list of included assets before deciding to serve index.html #40678

Comments

javiercn commented Mar 12, 2022 • edited

msftbot bot commented Mar 14, 2022

allprogrammers commented Mar 28, 2022

javiercn commented Mar 28, 2022

allprogrammers commented Mar 29, 2022 • edited

javiercn commented Mar 12, 2022 •

edited

allprogrammers commented Mar 29, 2022 •

edited