The Wayback Machine - https://web.archive.org/web/20220709100039/https://github.com/dotnet/machinelearning/issues/4182
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatabaseLoader] Create higher level convenient methods for DatabaseLoader #4182

Open
CESARDELATORRE opened this issue Sep 6, 2019 · 1 comment
Labels
enhancement good first issue P2
Milestone

Comments

@CESARDELATORRE
Copy link
Contributor

@CESARDELATORRE CESARDELATORRE commented Sep 6, 2019

As mentioned by Diego, these additions would help by simplifying the API usage for users even further and it should be pretty easy to implement for us: 👍

@divega commented: dotnet/machinelearning-samples#617 (review)

@CESARDELATORRE, I did a deferred review. The experience seems pretty good.

1:
And I agree with you that it could be even better with some sugar method that loads directly from the arguments of DatabaseSource.

2:
I can also see other possible shortcuts of similar nature. For example, although DbProviderFactory is the all encompassing root concept if you need everything from an ADO.NET provider, a DbConnection can give you everything but DbConnectionStringBuilder, and it is a much more familiar abstraction for most users than the DbProviderFactory. So, unless you need to manipulate connection strings in a provider agnostic way (not commonly an useful thing to do), you could make the sugar Load method generic on the provider's DbConnection type.
All in all, I would would love to meet with you and the devs and walk trough the product code and API. It is likely that more things like this will come up.

@CESARDELATORRE CESARDELATORRE added the enhancement label Sep 6, 2019
@CESARDELATORRE CESARDELATORRE added the up-for-grabs label Oct 2, 2019
@eerhardt eerhardt added good first issue and removed up-for-grabs labels Oct 2, 2019
@Pomoinytskyi
Copy link

@Pomoinytskyi Pomoinytskyi commented Dec 27, 2019

Hi @divega and @CESARDELATORRE

I am interested in this task. Could you please explain what sugar methods you want to have in more details?
You wrote:

you could make the sugar Load method generic on the provider's DbConnection type

What providers type do you mean under

provider's DbConnection type

if I am correctly understand you, it is not the DbProviderFactory.

I can propose such methods:
public static IDataView Load<TData>(this DbConnection connection, string connectionString, string query, IHostEnvironment host)
or
public static IDataView Load<TData>(this DatabaseSource source, string connectionString, string query, IHostEnvironment host)

Thanks.

@antoniovs1029 antoniovs1029 added the P2 label Jan 9, 2020
@eerhardt eerhardt removed their assignment Mar 17, 2020
@tannergooding tannergooding removed their assignment Jun 12, 2022
@michaelgsharp michaelgsharp added this to the ML.NET Future milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue P2
Projects
None yet
Development

No branches or pull requests

6 participants