The Wayback Machine - https://web.archive.org/web/20221103081141/https://github.com/kubernetes/kubernetes/pull/109757
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testcases for pkg/kubelet/cm/pod_container_manager_linux.go #109757

Merged
merged 3 commits into from Nov 3, 2022
Merged

Add testcases for pkg/kubelet/cm/pod_container_manager_linux.go #109757

merged 3 commits into from Nov 3, 2022
+167 −0

Conversation

STRRL
Copy link
Contributor

@STRRL STRRL commented May 2, 2022 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR:

  • appends test cases for podContainerManagerImpl, method GetPodContainerName;
    • assert that it should return the name of QoS Class as a part of CgroupName and LiteralCgroupfs
    • assert that it could works with different cgroup drivers as systemd and cgroupfs
  • append test case for podContainerManagerImpl, method IsPodCgroup, with reserved word "pod"

Which issue(s) this PR fixes:

It is a part of #109717;

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Signed-off-by: STRRL [email protected]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 2, 2022

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 2, 2022

Welcome @STRRL!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 2, 2022

Hi @STRRL. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@STRRL
Copy link
Contributor Author

STRRL commented May 2, 2022

/sig node

@k8s-ci-robot k8s-ci-robot requested review from matthyx and yujuhong May 2, 2022
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/kubelet and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2022
@STRRL
Copy link
Contributor Author

STRRL commented May 2, 2022

/cc @endocrimes @fromanirh

@STRRL STRRL changed the title test: testcases for pod container manager GetPodContainerName Add testcases for pkg/kubelet/cm/pod_container_manager_linux.go May 2, 2022
@matthyx
Copy link
Contributor

matthyx commented May 4, 2022

Welcome @STRRL !
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2022
@endocrimes endocrimes added this to Triage in SIG Node PR Triage May 4, 2022
@STRRL
Copy link
Contributor Author

STRRL commented May 4, 2022

/retest-required

these failed test cases are not related to this PR.

@STRRL
Copy link
Contributor Author

STRRL commented May 5, 2022

Hi @matthyx @endocrimes , it seems tests are passed, what should I do now? :)

@matthyx
Copy link
Contributor

matthyx commented May 9, 2022

@STRRL: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

We will triage this during our weekly meeting on Wednesday.

endocrimes
endocrimes approved these changes Aug 8, 2022
View changes
Copy link
Member

@endocrimes endocrimes left a comment

/lgtm
/approve

@endocrimes
Copy link
Member

endocrimes commented Aug 8, 2022

test failure looks like a flake

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@endocrimes endocrimes moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Aug 8, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 7, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 7, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2022

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Needs Approver to Done Oct 7, 2022
@pacoxu
Copy link
Member

pacoxu commented Oct 8, 2022

/remove-lifecycle rotten
/reopen
The pr seems to be valid
/lgtm

@k8s-ci-robot k8s-ci-robot reopened this Oct 8, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2022

@pacoxu: Reopened this PR.

In response to this:

/remove-lifecycle rotten
/reopen
The pr seems to be valid
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node PR Triage automation moved this from Done to Triage Oct 8, 2022
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 8, 2022
@pacoxu pacoxu moved this from Triage to Needs Approver in SIG Node PR Triage Oct 8, 2022
@pacoxu
Copy link
Member

pacoxu commented Oct 8, 2022

/assign @dchen1107

mrunalp
mrunalp approved these changes Nov 1, 2022
View changes
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, mrunalp, STRRL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Nov 1, 2022
@pacoxu
Copy link
Member

pacoxu commented Nov 3, 2022

/retest
for flake

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 3, 2022

@STRRL: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 1dcd0c3 link unknown /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

pacoxu commented Nov 3, 2022

/skip
/retest

@k8s-ci-robot k8s-ci-robot merged commit 6754265 into kubernetes:master Nov 3, 2022
13 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp

@endocrimes endocrimes

@matthyx matthyx

@yujuhong yujuhong

@fromanirh fromanirh

Assignees

@endocrimes endocrimes

@dchen1107 dchen1107

@fromanirh fromanirh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@STRRL @k8s-ci-robot @matthyx @k8s-triage-robot @endocrimes @pacoxu @mrunalp @dchen1107 @fromanirh