symfony / symfony Public

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Stand with Ukraine

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

On 4.4
![image](https://user-images.githubusercontent.com/47313/157268381-2cf9466b-a7b8-4879-af6a-e60833e32d12.png)

On 5.4
![image](https://user-images.githubusercontent.com/47313/157268499-6dbd7be8-1584-4a50-8717-872554739136.png)

Commits
-------

0558ea3 Fix colors for 4.4
37ca066 Stand with Ukraine

… in EmumNode in 6.1 (ecourtial)

This PR was merged into the 4.4 branch.

Discussion
----------

Remove blocking test for adding support for placeholders in EmumNode in 6.1

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Remove blocking test for the PR #45624

Commits
-------

a0bce33 Remove blocking test for adding support for placeholders in EmumNode in 6.1

…(nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Ensure container is reset between tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #45668
| License       | MIT
| Doc PR        | -

Calling boot() resets the container only is a request was handled before.
Since this is not always the case here, we need to reset the container explicitly.

Commits
-------

608b1dd [FrameworkBundle] Ensure container is reset between tests

released v4.4.39

…in 6.1

…otModified` (HypeMC)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] Fix PHP 8.1 deprecation in `Response::isNotModified`

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

If an `If-None-Match` header is provided in the request and there's no `ETag` header in the response, the following deprecation notice occurs on PHP 8.1 in `Response::isNotModified`:

```
Deprecated: strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated
```

Commits
-------

b909acf [HttpFoundation] Fix PHP 8.1 deprecation in isNotModified

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Guard against bad profile data

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #45606
| License       | MIT
| Doc PR        | -

Commits
-------

f4a2089 [HttpKernel] Guard against bad profile data

This PR was merged into the 4.4 branch.

Discussion
----------

Fix deprecations on PHP 8.2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | On the road to #44282
| License       | MIT
| Doc PR        | -

Commits
-------

ca56620 Fix deprecations on PHP 8.2

…icolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Fix resetting container between tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40965, fix #45580
| License       | MIT
| Doc PR        | -

Replaces #45479 and #45581, related to #34078.

Calling `boot()` on an already booted kernel does reset the container, so we don't need to care anymore about the state of kernel.

#45580 is fixed by removing `private static $kernelContainer`, which can be out of sync with `static::$kernel->getContainer()` since `KernelBrowser` creates new containers when shutting down the kernel between requests.

Commits
-------

4453bdb [FrameworkBundle] Fix resetting container between tests

….4 (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix checking for unset property on PHP <= 7.1.4

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As spotted by the CI and confirmed here: https://3v4l.org/2Xv3N

Commits
-------

721996a [HttpClient] fix checking for unset property on PHP <= 7.1.4

…d by #44570 (xavismeh)

This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] Fixes HTML syntax regression introduced by #44570

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

The PR #44570 introduced an invalid HTML syntax and this PR fixes this regression

Commits
-------

c555813 [WebProfilerBundle] Fixes HTML syntax regression introduced by #44570

released v4.4.38

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Handle requests with null body

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

since #45527 passing null to the `body` parameters leads to an exception (which [breaks async-aws](https://github.com/async-aws/aws/blob/09723ddca29b8d1d522426f81dd422373de1785f/src/Core/src/AbstractApi.php#L157))

> Argument #2 ($body) must be of type Closure, null given, called in /home/runner/work/aws/aws/vendor/symfony/http-client/CurlHttpClient.php on line 221

In curl client: `null` is not a string and `self::readRequestBody` expects a closure.

https://github.com/symfony/symfony/blob/08fa74a16c84895575e305b2a7ee3a03e371f79b/src/Symfony/Component/HttpClient/CurlHttpClient.php#L214-L221

In NativeClient, `getBodyAsString` will fail to return `null` because of the `string` return type.

Before #45527 null was converted to `""` thanks to the defaultOptions, but this is not the case anymore.

In many places, we check if the body is `!== ""` but rarely check if the body is null, this PR restores the original behaviors for the `body` parameters and converts nulls to `""`.

Commits
-------

39aec09 [HttpClient] Handle requests with null body

This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] add nonces to profiler

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #44472
| License       | MIT
| Doc PR        | none

Commits
-------

cbd670f add nonces to profiler

…essenger (Giorgio Premi)

This PR was merged into the 4.4 branch.

Discussion
----------

MailerInterface: failed exception contract when enabling messenger

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | likely not required...

The interface for MailerInterface::send states that exception for
transport failures are sent as TransportExceptionInterface, which
make perfectly sense and allows to create solid UI.

If at later stage the Messenger component is enabled, the mail will
be rewired into a dispatched message, which by default is synchronous.
This cause all exception to be wrapped into HandlerFailedException
which doesn't the interface contract.

In the end the UI is broken, and the exception HandlerFailedException,
even if caught, is totally unrelated to the usage context as it is only
related to configuration details.

This patch will unwrap the underlying MailTransportInterface exception
if available for the handler exception.

PS: don't know if make sense to add a phpunit test for this cross-component scenario, if so I'll try. Also, this will restore compatibility with interface, but I don't if it's to be considered a BC (strictly speaking, it may be)

Commits
-------

4e29672 MailerInterface: failed exception contract when enabling messenger

…ints (fancyweb)

This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] Improve tests for the Image and File constraints

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | -
| Tickets       | -
| License       | MIT
| Doc PR        | -

For #45090 but submitting it on the lowest branch possible.

Commits
-------

1a82c71 [Validator] Improve tests for the Image and File constraints