[DependencyInjection] Fix "proxy" tag: resolve its parameters and pass it to child definitions #46448
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
May 24, 2022
…s it to child definitions
|
Btw, this makes me think that the clean representation for the proxy type might be a dedicated property in the definition rather than a tag (but this cannot be changed in 4.4 anyway) |
Mostly yes, or make |
chalasr
approved these changes
May 25, 2022
fabpot
approved these changes
May 27, 2022
|
Thank you @nicolas-grekas. |
This was referenced May 27, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Forgotten in #27697
"proxy" tags are special: they must follow like the "lazy" attribute of definitions.